From: Jens Axboe <axboe@kernel.dk>
To: Omar Sandoval <osandov@osandov.com>, linux-block@vger.kernel.org
Cc: kernel-team@fb.com, Jordan Glover <Golden_Miller83@protonmail.ch>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2] kyber: fix wrong strlcpy() size in trace_kyber_latency()
Date: Mon, 12 Nov 2018 08:29:17 -0700 [thread overview]
Message-ID: <81f37068-4e6b-0d76-d547-932e4ea4a916@kernel.dk> (raw)
In-Reply-To: <7cd2a3c7ceed5dea16bc4ccf8edad77e90a49e7a.1542010053.git.osandov@fb.com>
On 11/12/18 1:08 AM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> When copying to the latency type, we should be passing LATENCY_TYPE_LEN,
> not DOMAIN_LEN (this isn't a problem in practice because we only pass
> "total" or "I/O"). Fix it by changing all of the strlcpy() calls to use
> sizeof().
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-12 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 8:08 [PATCH v2] kyber: fix wrong strlcpy() size in trace_kyber_latency() Omar Sandoval
2018-11-12 13:52 ` Jordan Glover
2018-11-12 15:29 ` Jens Axboe [this message]
2018-11-12 15:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81f37068-4e6b-0d76-d547-932e4ea4a916@kernel.dk \
--to=axboe@kernel.dk \
--cc=Golden_Miller83@protonmail.ch \
--cc=bvanassche@acm.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox