From: Damien Le Moal <dlemoal@kernel.org>
To: Chaitanya Kulkarni <kch@nvidia.com>, linux-block@vger.kernel.org
Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, bvanassche@acm.org,
vincent.fu@samsung.com, shinichiro.kawasaki@wdc.com,
error27@gmail.com
Subject: Re: [PATCH] null_blk: fix queue mode Oops for membacked
Date: Wed, 12 Apr 2023 16:57:19 +0900 [thread overview]
Message-ID: <824e2454-14d8-35b8-bfdb-ae26df255003@kernel.org> (raw)
In-Reply-To: <20230412040827.8082-1-kch@nvidia.com>
On 4/12/23 13:08, Chaitanya Kulkarni wrote:
> Make sure to check device queue mode in the null_validate_conf()
> and return error for NULL_Q_RQ as we don't allow legacy I/O path,
> without this patch we get OOPs when queue mode is set to 1 from
> configfs, following are repro steps :-
Looks OK but the patch title is a little odd as I do not see what memory backing
has to do with checking the correctness of queue_mode. So what about something like:
null_blk: Always check queue mode setting from configfs
for the patch title ?
With that fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
next prev parent reply other threads:[~2023-04-12 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230412091807epcas5p10b99767a999ded5789cb8ffce2189394@epcas5p1.samsung.com>
2023-04-12 4:08 ` [PATCH] null_blk: fix queue mode Oops for membacked Chaitanya Kulkarni
2023-04-12 7:57 ` Damien Le Moal [this message]
2023-04-12 8:09 ` Chaitanya Kulkarni
2023-04-12 9:17 ` Nitesh Shetty
2023-04-12 9:43 ` Damien Le Moal
2023-04-12 10:29 ` Nitesh Shetty
2023-04-13 1:30 ` Chaitanya Kulkarni
2023-04-13 3:24 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824e2454-14d8-35b8-bfdb-ae26df255003@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=error27@gmail.com \
--cc=johannes.thumshirn@wdc.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox