From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Damien Le Moal <damien.lemoal@wdc.com>,
Niklas Cassel <Niklas.Cassel@wdc.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 4/4] block/mq-deadline: Prioritize high-priority requests
Date: Mon, 27 Sep 2021 16:12:10 -0700 [thread overview]
Message-ID: <82e092db-5d54-6c20-4fa1-3c0d860003dd@acm.org> (raw)
In-Reply-To: <1d0893c3-da0a-e473-e37d-15df8e6d468e@opensource.wdc.com>
On 9/27/21 3:53 PM, Damien Le Moal wrote:
> On 2021/09/28 7:03, Bart Van Assche wrote:
>> /*
>> * deadline_dispatch_requests selects the best request according to
>> - * read/write expire, fifo_batch, etc
>> + * read/write expire, fifo_batch, etc and with a start time <= @latest.
>
> s/@latest/@latest_start ?
>
>> */
>> static struct request *__dd_dispatch_request(struct deadline_data *dd,
>> - struct dd_per_prio *per_prio)
>> + struct dd_per_prio *per_prio,
>> + unsigned long latest_start)
Right, the comment above this function needs to be updated.
Bart.
next prev parent reply other threads:[~2021-09-27 23:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 22:03 [PATCH v2 0/4] Restore I/O priority support in the mq-deadline scheduler Bart Van Assche
2021-09-27 22:03 ` [PATCH v2 1/4] block/mq-deadline: Improve request accounting further Bart Van Assche
2021-09-28 5:45 ` Hannes Reinecke
2021-09-27 22:03 ` [PATCH v2 2/4] block/mq-deadline: Add an invariant check Bart Van Assche
2021-09-28 5:47 ` Hannes Reinecke
2021-09-27 22:03 ` [PATCH v2 3/4] block/mq-deadline: Stop using per-CPU counters Bart Van Assche
2021-09-28 5:51 ` Hannes Reinecke
2021-09-28 17:35 ` Bart Van Assche
2021-09-27 22:03 ` [PATCH v2 4/4] block/mq-deadline: Prioritize high-priority requests Bart Van Assche
2021-09-27 22:53 ` Damien Le Moal
2021-09-27 23:12 ` Bart Van Assche [this message]
2021-09-28 5:53 ` Hannes Reinecke
2021-09-28 10:36 ` Niklas Cassel
2022-03-25 12:33 ` Oleksij Rempel
2022-03-25 13:07 ` Oleksij Rempel
2022-03-25 17:05 ` Bart Van Assche
2022-03-26 8:57 ` Oleksij Rempel
2022-03-28 2:20 ` Bart Van Assche
2022-03-28 22:24 ` Bart Van Assche
2022-03-29 4:49 ` Bart Van Assche
2021-09-27 23:14 ` [PATCH v2 0/4] Restore I/O priority support in the mq-deadline scheduler Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e092db-5d54-6c20-4fa1-3c0d860003dd@acm.org \
--to=bvanassche@acm.org \
--cc=Niklas.Cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).