From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <dlemoal@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] null_blk: Always split BIOs to respect queue limits
Date: Fri, 26 Jan 2024 08:05:21 +0100 [thread overview]
Message-ID: <84dce2ee-5d71-47a4-b114-3ca69b3c31fb@suse.de> (raw)
In-Reply-To: <20240126005032.1985245-1-dlemoal@kernel.org>
On 1/26/24 01:50, Damien Le Moal wrote:
> The function null_submit_bio() used for null_blk devices configured
> with a BIO-based queue never splits BIOs according to the queue limits
> set with the various module and configfs parameters that the user can
> specify.
>
> Add a call to bio_split_to_limits() to correctly handle large
> BIOs that need splitting. Doing so also fixes issues with zoned devices
> as a large BIO may cross over a zone boundary, which breaks null_blk
> zone emulation.
>
That feels so wrong. Why would we need to apply queue limits to a bio?
(Yes, I know why. We still shouldn't be doing it.)
Maybe indeed time to kill the bio-based path.
But until that happens:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich
next prev parent reply other threads:[~2024-01-26 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 0:50 [PATCH] null_blk: Always split BIOs to respect queue limits Damien Le Moal
2024-01-26 7:05 ` Hannes Reinecke [this message]
2024-01-26 7:09 ` Damien Le Moal
2024-01-26 8:37 ` Chaitanya Kulkarni
2024-01-26 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84dce2ee-5d71-47a4-b114-3ca69b3c31fb@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox