Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>,
	Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: Paolo Valente <paolo.valente@linaro.org>,
	BLOCK ML <linux-block@vger.kernel.org>,
	Omar Sandoval <osandov@fb.com>
Subject: Re: [RFC] iosched: add cfq -> bfq alias
Date: Wed, 24 Mar 2021 16:16:25 -0600	[thread overview]
Message-ID: <85fec70c-e908-7828-503a-59f313bb454a@kernel.dk> (raw)
In-Reply-To: <6dc9784e-9eb3-6f99-9200-7f39a91fc180@gmail.com>

On 3/24/21 4:10 PM, Xose Vazquez Perez wrote:
> On 3/7/21 8:26 PM, Oleksandr Natalenko wrote:
> 
>> Hmmm NACK.
>>
>> CFQ and BFQ are completely different beasts.
>>
>> If you are going to tune BFQ to match old CFQ behaviour (somehow; I
>> don't know why one would do this, how one would do this and whether it
>> is possible at all), you for sure have enough time to fix your old udev
>> rules and scripts.
>>
>> If you are just tolerating default BFQ behaviour, you should explicitly
>> acknowledge it by amending your rules and scripts. For personal systems
>> this is not a big deal. For enterprise systems you better do it NOW so
>> that another person that comes to work on those systems in 10 years
>> after you resign knows what and why was done.
>>
>> If you are just lazy (no offence! I don't know your real intention
>> here), I'm not sure we are going to hide such an indifference behind
>> another aliasing kludge.
>>
>> Thanks.
>>
> 
> You are writing a lot, and say nothing.
> 
> bfq is the natural choice coming from cfq. There is NO other option.
> 
> Still waiting... for a valid *technical* response against my change.

Let's lay off the aggression a bit, it's not helpful.

They are two very different schedulers. Yes, they support some of the
same options, but they really have nothing in common outside of that. On
top of that, it's also very late to introduce a change like that, it
should've been done with the introduction of it.

> Or do you prefer to apply the below patch?.

Not a valid example, as mq-deadline and deadline are identical, one just
supports multiple queues.

-- 
Jens Axboe


      reply	other threads:[~2021-03-24 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 22:46 [RFC] iosched: add cfq -> bfq alias Xose Vazquez Perez
2021-03-07 19:26 ` Oleksandr Natalenko
2021-03-24 22:10   ` Xose Vazquez Perez
2021-03-24 22:16     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85fec70c-e908-7828-503a-59f313bb454a@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=oleksandr@natalenko.name \
    --cc=osandov@fb.com \
    --cc=paolo.valente@linaro.org \
    --cc=xose.vazquez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox