From: NeilBrown <neilb@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread.
Date: Wed, 05 Apr 2017 14:27:02 +1000 [thread overview]
Message-ID: <8760ijiind.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <20170404071033.GA25855@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Tue, Apr 04 2017, Christoph Hellwig wrote:
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> But if you actually care about performance in any way I'd suggest
> to use the loop device in direct I/O mode..
The losetup on my test VM is too old to support that :-(
I guess it might be time to upgraded.
It seems that there is not "mount -o direct_loop" or similar, so you
have to do the losetup and the mount separately. Any thoughts on
whether that should be changed ?
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-05 4:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 1:18 [PATCH] loop: Add PF_LESS_THROTTLE to block/loop device thread NeilBrown
2017-04-04 7:10 ` Christoph Hellwig
2017-04-05 4:27 ` NeilBrown [this message]
2017-04-05 5:13 ` Ming Lei
2017-04-04 11:23 ` Michal Hocko
2017-04-04 14:24 ` Ming Lei
2017-04-05 4:31 ` NeilBrown
2017-04-05 4:33 ` [PATCH v2] " NeilBrown
2017-04-05 5:05 ` Ming Lei
2017-04-05 7:19 ` Michal Hocko
2017-04-05 7:32 ` Michal Hocko
2017-04-06 2:23 ` NeilBrown
2017-04-06 6:53 ` Michal Hocko
2017-04-06 23:47 ` [PATCH v3] " NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760ijiind.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).