From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CC76C54EBE for ; Fri, 13 Jan 2023 13:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241525AbjAMNjW (ORCPT ); Fri, 13 Jan 2023 08:39:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241828AbjAMNil (ORCPT ); Fri, 13 Jan 2023 08:38:41 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB3B10C1; Fri, 13 Jan 2023 05:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673616810; x=1705152810; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=SIimS6dlFX7jkCJ504BScuOul7TISPli5vt+Yekfd2g=; b=JWqMAXaI3NY0NUrLwAfgHteNbeUosSi9422ea7XNGO4HvafBN6G8IUci Tz6SonHdvmmseG03Df+B1a1WhRVd+UnYs92xoGf5LWwl9bkc0E1eSlZjZ 2GN2u06a+fWZD1aobmavS2IK0OxZYunczGFlq/k+pa4DfZ5IUAurveZrO mWQbglwK1ZQ1n/PinYgWdUUKZcbZZRuNFfmN00+rgrqQholH08WjiDaKo yA+8l2oj1yg2W7krbwHY2M1CjWjxAqfi9SplyZ+mLA9PslisIFrRspMYD a8toEbJPgomuMgcKIkd8nb2JnUE6gPuWgkPd3ME+soWR1XwxuzBzDIKrW g==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="351224602" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="351224602" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2023 05:33:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="903572429" X-IronPort-AV: E=Sophos;i="5.97,214,1669104000"; d="scan'208";a="903572429" Received: from ubik.fi.intel.com (HELO localhost) ([10.237.72.184]) by fmsmga006.fm.intel.com with ESMTP; 13 Jan 2023 05:33:23 -0800 From: Alexander Shishkin To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Jens Axboe , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Jeremy Kerr , Joel Stanley , Alistar Popple , Eddie James , Jonathan Cameron , Jilin Yuan , Heikki Krogerus , Alan Stern , Andy Shevchenko , Thomas Gleixner , Jason Gunthorpe , "Rafael J. Wysocki" , Won Chung , linux-block@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsi@lists.ozlabs.org, linux-usb@vger.kernel.org, Dan Williams , alexander.shishkin@linux.intel.com Subject: Re: [PATCH v2 06/16] driver core: make struct device_type.devnode() take a const * In-Reply-To: <20230111113018.459199-7-gregkh@linuxfoundation.org> References: <20230111113018.459199-1-gregkh@linuxfoundation.org> <20230111113018.459199-7-gregkh@linuxfoundation.org> Date: Fri, 13 Jan 2023 15:33:16 +0200 Message-ID: <877cxqsgo3.fsf@ubik.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Greg Kroah-Hartman writes: > The devnode() callback in struct device_type should not be modifying the > device that is passed into it, so mark it as a const * and propagate the > function signature changes out into all relevant subsystems that use > this callback. For the intel-th bit: Acked-by: Alexander Shishkin Thanks, -- Alex