From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCHSET] Add support for simplified async direct-io
Date: Thu, 17 Nov 2016 08:03:46 -0700 [thread overview]
Message-ID: <87823f67-a2ec-e959-1a23-9ecf3d6fe6d4@kernel.dk> (raw)
In-Reply-To: <204d4a18-e5da-1806-433e-a3ff1b6ca575@kernel.dk>
On 11/17/2016 06:25 AM, Jens Axboe wrote:
> On 11/17/2016 05:50 AM, Christoph Hellwig wrote:
>> On Wed, Nov 16, 2016 at 09:43:57PM -0700, Jens Axboe wrote:
>>> OK, I'm getting reasonably happy with it now:
>>>
>>> http://git.kernel.dk/cgit/linux-block/log/?h=for-4.10/hch-dio
>>>
>>> Sharing the FUA setting to avoid the manual flush between the two, and
>>> removing the remnants of SYNC support from __blkdev_direct_IO().
>>>
>>> I'll fire off some overnight testing now and leave it for the day.
>>
>> This looks reasonable, a couple questions and comments:
>>
>> - why the 8 * BIO_MAX_PAGES in the call to iov_iter_npages,
>> that probably needs a comment
>
> Looks like I forgot to push out the latest changes, that is gone. We're
> just using + 1 now to see if we should use the multibio function or not.
Just to clarify, the correct tip is:
commit 18eb8e94477813c190a2dfcd790c6707ab168377
Author: Jens Axboe <axboe@fb.com>
Date: Wed Nov 16 23:20:41 2016 -0700
block: save 8 bytes of space in struct blkdev_dio
That's what I ran in my overnight testing, and it looks fine from my
end.
--
Jens Axboe
next prev parent reply other threads:[~2016-11-17 15:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 17:28 [PATCHSET] Add support for simplified async direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 1/2] block: support any sized IO for simplified bdev direct-io Jens Axboe
2016-11-14 17:28 ` [PATCH 2/2] block: add support for async simple direct-io for bdevs Jens Axboe
2016-11-14 17:37 ` [PATCHSET] Add support for simplified async direct-io Christoph Hellwig
2016-11-14 17:47 ` Jens Axboe
2016-11-14 18:00 ` Christoph Hellwig
2016-11-14 18:02 ` Jens Axboe
2016-11-14 18:05 ` Christoph Hellwig
2016-11-14 18:08 ` Jens Axboe
2016-11-14 18:11 ` Christoph Hellwig
2016-11-14 18:17 ` Jens Axboe
2016-11-15 13:58 ` Christoph Hellwig
2016-11-16 16:09 ` Jens Axboe
2016-11-16 16:31 ` Christoph Hellwig
2016-11-16 16:57 ` Jens Axboe
2016-11-16 17:16 ` Christoph Hellwig
2016-11-16 20:02 ` Jens Axboe
2016-11-16 20:36 ` Jens Axboe
2016-11-16 20:51 ` Jens Axboe
2016-11-17 3:44 ` Jens Axboe
2016-11-17 4:43 ` Jens Axboe
2016-11-17 12:50 ` Christoph Hellwig
2016-11-17 13:25 ` Jens Axboe
2016-11-17 15:03 ` Jens Axboe [this message]
2016-11-17 15:16 ` Christoph Hellwig
2016-11-17 20:17 ` Christoph Hellwig
2016-11-17 20:30 ` Jens Axboe
2016-11-17 21:04 ` Christoph Hellwig
2016-11-17 21:06 ` Jens Axboe
2016-11-17 12:46 ` Christoph Hellwig
2016-11-17 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87823f67-a2ec-e959-1a23-9ecf3d6fe6d4@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).