public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Nix <nix@esperi.org.uk>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
	Pavel Goran <via-bcache@pvgoran.name>,
	Michael Lyle <mlyle@lyle.org>,
	Junhui Tang <tang.junhui@zte.com.cn>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH v5 06/10] bcache: add stop_when_cache_set_failed option to backing device
Date: Tue, 06 Feb 2018 10:50:30 +0000	[thread overview]
Message-ID: <87bmh25r49.fsf@esperi.org.uk> (raw)
In-Reply-To: <20180206042100.65021-7-colyli@suse.de> (Coly Li's message of "Tue, 6 Feb 2018 12:20:56 +0800")

On 6 Feb 2018, Coly Li verbalised:
> diff --git a/drivers/md/bcache/bcache.h b/drivers/md/bcache/bcache.h
> index 7917b3820dd5..263164490833 100644
> --- a/drivers/md/bcache/bcache.h
> +++ b/drivers/md/bcache/bcache.h
> @@ -287,6 +287,12 @@ struct io {
>  	sector_t		last;
>  };
>  
> +enum stop_on_faliure {

failure?

> +	BCH_CACHED_DEV_STOP_ATUO = 0,

AUTO?

> +	enum stop_on_faliure	stop_when_cache_set_failed;

(... and all uses would need changing too.)

-- 
NULL && (void)

  reply	other threads:[~2018-02-06 10:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06  4:20 [PATCH v5 00/10] bcache: device failure handling improvement Coly Li
2018-02-06  4:20 ` [PATCH v5 01/10] bcache: set writeback_rate_update_seconds in range [1, 60] seconds Coly Li
2018-02-07 17:31   ` Michael Lyle
2018-02-06  4:20 ` [PATCH v5 02/10] bcache: fix cached_dev->count usage for bch_cache_set_error() Coly Li
2018-02-06  4:20 ` [PATCH v5 03/10] bcache: quit dc->writeback_thread when BCACHE_DEV_DETACHING is set Coly Li
2018-02-07 17:35   ` Michael Lyle
2018-02-06  4:20 ` [PATCH v5 04/10] bcache: stop dc->writeback_rate_update properly Coly Li
2018-02-06  4:20 ` [PATCH v5 05/10] bcache: add CACHE_SET_IO_DISABLE to struct cache_set flags Coly Li
2018-02-06  4:20 ` [PATCH v5 06/10] bcache: add stop_when_cache_set_failed option to backing device Coly Li
2018-02-06 10:50   ` Nix [this message]
2018-02-06 11:24     ` Coly Li
2018-02-07 17:36   ` Michael Lyle
2018-02-06  4:20 ` [PATCH v5 07/10] bcache: fix inaccurate io state for detached bcache devices Coly Li
2018-02-07 17:39   ` Michael Lyle
2018-02-06  4:20 ` [PATCH v5 08/10] bcache: add backing_request_endio() for bi_end_io of attached backing device I/O Coly Li
2018-02-06  4:20 ` [PATCH v5 09/10] bcache: add io_disable to struct cached_dev Coly Li
2018-02-06  4:21 ` [PATCH v5 10/10] bcache: stop bcache device when backing device is offline Coly Li
  -- strict thread matches above, loose matches on Subject: below --
2018-02-06 11:23 [PATCH v5 06/10] bcache: add stop_when_cache_set_failed option to backing device Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmh25r49.fsf@esperi.org.uk \
    --to=nix@esperi.org.uk \
    --cc=colyli@suse.de \
    --cc=hare@suse.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mlyle@lyle.org \
    --cc=tang.junhui@zte.com.cn \
    --cc=via-bcache@pvgoran.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox