From: NeilBrown <neilb@suse.com>
To: Jens Axboe <axboe@fb.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Two fixes for loop devices
Date: Sun, 18 Jun 2017 14:33:09 +1000 [thread overview]
Message-ID: <87bmpl6hkq.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <c70dfc69-516c-f1e8-4e39-74eff1bca176@fb.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On Fri, Jun 16 2017, Jens Axboe wrote:
> On 06/15/2017 11:02 PM, NeilBrown wrote:
>> Hi Jens,
>> one of these is a resend of a patch I sent a while back.
>> The other is new - loop closes files differently from close()
>> and in a way that can confuse NFS.
>
> Are you wanting to get these into 4.12, or defer to 4.13?
I'm happy either way. I just want them to land eventually, so I can
tick them off my list.
The conversation with Al might result in a different fix for the
flip_close() problem, but I think that it is still more correct to call
filp_close(), because what loop is doing is a lot like closing a file
that it has been writing to.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-06-18 4:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 5:02 [PATCH 0/2] Two fixes for loop devices NeilBrown
2017-06-16 5:02 ` [PATCH 1/2] loop: use filp_close() rather than fput() NeilBrown
2017-06-16 7:37 ` Christoph Hellwig
2017-06-17 0:01 ` Al Viro
2017-06-18 4:30 ` NeilBrown
2017-06-16 5:02 ` [PATCH 2/2] loop: Add PF_LESS_THROTTLE to block/loop device thread NeilBrown
2017-06-16 7:36 ` Christoph Hellwig
2017-06-16 14:29 ` [PATCH 0/2] Two fixes for loop devices Jens Axboe
2017-06-18 4:33 ` NeilBrown [this message]
2017-06-18 15:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmpl6hkq.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).