Linux block layer
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Coly Li <colyli@suse.de>
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
	juha.aatrokoski@aalto.fi, shhuiw@foxmail.com
Subject: Re: [PATCH] bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
Date: Wed, 1 May 2019 06:35:31 -0600	[thread overview]
Message-ID: <87f49306-4b2e-111f-d6e3-e2929027f66d@kernel.dk> (raw)
In-Reply-To: <b9036b88-9bd9-a96b-a7ed-96bd45708267@suse.de>

On 5/1/19 12:43 AM, Coly Li wrote:
> On 2019/4/30 10:20 下午, Jens Axboe wrote:
>> On 4/30/19 8:05 AM, Coly Li wrote:
>>> On 2019/4/30 10:02 下午, Coly Li wrote:
>>>> Commit 95f18c9d1310 ("bcache: avoid potential memleak of list of
>>>> journal_replay(s) in the CACHE_SYNC branch of run_cache_set") forgets
>>>> to remove the original define of LIST_HEAD(journal), which makes
>>>> the change no take effect. This patch removes redundant variable
>>>> LIST_HEAD(journal) from run_cache_set(), to make Shenghui's fix
>>>> working.
>>>>
>>>> Reported-by: Juha Aatrokoski <juha.aatrokoski@aalto.fi>
>>>> Cc: Shenghui Wang <shhuiw@foxmail.com>
>>>> Signed-off-by: Coly Li <colyli@suse.de>
>>>> ---
>>>>  drivers/md/bcache/super.c | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
>>>> index 0ffe9acee9d8..1b63ac876169 100644
>>>> --- a/drivers/md/bcache/super.c
>>>> +++ b/drivers/md/bcache/super.c
>>>> @@ -1800,7 +1800,6 @@ static int run_cache_set(struct cache_set *c)
>>>>  	set_gc_sectors(c);
>>>>  
>>>>  	if (CACHE_SYNC(&c->sb)) {
>>>> -		LIST_HEAD(journal);
>>>>  		struct bkey *k;
>>>>  		struct jset *j;
>>>>  
>>>>
>>>
>>> Hi Jens,
>>>
>>> Please take this fix for the Linux v5.2 bcache series. It fixes a
>>> problem from
>>> [PATCH 18/18] bcache: avoid potential memleak of list of
>>> journal_replay(s) in the CACHE_SYNC branch of run_cache_set
>>> which is already in your for-next branch.
>>>
>>> Thanks to Juha for cache this bug, and thank you in advance for taking
>>> care of this.
>>
>> Applied, but please add Fixes: lines patches like that, it's not enough
>> to simply mention it in the commit message.
>>
> 
> I just re-send a V2 patch with adding the Fixes: line, thanks for taking
> care of this.

As I wrote, I already applied it and added the Fixes tag. Just a note
for future patches.

-- 
Jens Axboe


      reply	other threads:[~2019-05-01 12:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 14:02 [PATCH] bcache: remove redundant LIST_HEAD(journal) from run_cache_set() Coly Li
2019-04-30 14:05 ` Coly Li
2019-04-30 14:20   ` Jens Axboe
2019-05-01  6:43     ` Coly Li
2019-05-01 12:35       ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87f49306-4b2e-111f-d6e3-e2929027f66d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=juha.aatrokoski@aalto.fi \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=shhuiw@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox