From: Jonathan Corbet <corbet@lwn.net>
To: David Reaver <me@davidreaver.com>, Randy Dunlap <rdunlap@infradead.org>
Cc: David Reaver <me@davidreaver.com>, Jens Axboe <axboe@kernel.dk>,
Konstantin Khlebnikov <koct9i@gmail.com>,
linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: iostats: Rewrite intro, remove outdated formats
Date: Fri, 14 Feb 2025 08:48:15 -0700 [thread overview]
Message-ID: <87frkgzfwg.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250214051432.207630-1-me@davidreaver.com>
David Reaver <me@davidreaver.com> writes:
> The discussion of file formats for very old kernel versions obscured the
> key information in this document. Additionally, the introduction was
> missing a discussion of flush fields added in b6866318657 ("block: add
> iostat counters for flush requests") [1].
>
> Rewrite the introduction to discuss only the current kernel's disk I/O stat
> file formats. Also, clean up wording to be more concise.
>
> Link: https://lore.kernel.org/lkml/157433282607.7928.5202409984272248322.stgit@buzz/T/ [1]
>
> Signed-off-by: David Reaver <me@davidreaver.com>
> ---
>
> Thanks for the encouragement Randy. Here is a rewrite of the intro.
>
> This patch is mutually exclusive with the original patch I started this
> thread with. Let me know if I should submit it as a standalone thread.
> (I'm fairly new to contributing to the kernel.)
As a separate thread is generally better; no need to resend, though, if
there are no other changes.
But ... I'm not quite sure what "mutually exclusive" means here. That
they don't conflict, or that they cannot both be applied...?
Thanks,
jon
next prev parent reply other threads:[~2025-02-14 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 1:39 [PATCH] docs: iostats: Update introduction with flush fields David Reaver
2025-02-14 2:21 ` Randy Dunlap
2025-02-14 5:14 ` [PATCH] docs: iostats: Rewrite intro, remove outdated formats David Reaver
2025-02-14 10:21 ` Bagas Sanjaya
2025-02-14 15:48 ` Jonathan Corbet [this message]
2025-02-14 15:56 ` David Reaver
[not found] ` <CALYGNiOU3vPAyvsNv4rt=qZRbZFVZ9iAe+kzPzGKkx6_L3wG5Q@mail.gmail.com>
2025-02-14 17:39 ` David Reaver
2025-02-15 17:18 ` Konstantin Khlebnikov
2025-02-15 17:29 ` David Reaver
2025-02-15 17:46 ` Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frkgzfwg.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=axboe@kernel.dk \
--cc=koct9i@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox