public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
To: Keith Busch <keith.busch@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	 linux-block@vger.kernel.org,
	 Bart Van Assche <Bart.VanAssche@sandisk.com>,
	 linux-nvme@lists.infradead.org
Subject: Re: [PATCH] blk-mq: Take tagset lock when updaing hw queues
Date: Tue, 30 May 2017 16:52:14 -0300	[thread overview]
Message-ID: <87fufmm8b5.fsf@dilma.collabora.co.uk> (raw)
In-Reply-To: <1496169551-26868-1-git-send-email-keith.busch@intel.com> (Keith Busch's message of "Tue, 30 May 2017 14:39:11 -0400")

Keith Busch <keith.busch@intel.com> writes:

> The tagset lock needs to be held when iterating the tag_list, so a
> lockdep assert was added when updating number of hardware queues. The
> drivers calling this API, however, were unaware of the new requirement,
> so are failing the assertion.
>
> This patch takes the lock within the blk-mq function so the drivers do
> not have to be modified in order to be safe.
>
> Fixes: 705cda97e ("blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list")
>
> Reported-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
> Signed-off-by: Keith Busch <keith.busch@intel.com>

I know it is already applied but, FWIW, I can confirm it fixed the issue
in our CI.  Feel free to add:

Tested-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>

Thanks again, Keith.

-- 
Gabriel Krisman Bertazi

      parent reply	other threads:[~2017-05-30 19:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30 18:39 [PATCH] blk-mq: Take tagset lock when updaing hw queues Keith Busch
2017-05-30 18:32 ` Jens Axboe
2017-05-30 19:52 ` Gabriel Krisman Bertazi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fufmm8b5.fsf@dilma.collabora.co.uk \
    --to=krisman@collabora.co.uk \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=axboe@kernel.dk \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox