From: Jonathan Corbet <corbet@lwn.net>
To: David Reaver <me@davidreaver.com>
Cc: David Reaver <me@davidreaver.com>,
Randy Dunlap <rdunlap@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Konstantin Khlebnikov <koct9i@gmail.com>,
linux-doc@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: iostats: Rewrite intro, remove outdated formats
Date: Tue, 18 Feb 2025 13:30:10 -0700 [thread overview]
Message-ID: <87ldu3ngh9.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250215180114.157948-1-me@davidreaver.com>
David Reaver <me@davidreaver.com> writes:
> The introduction discussed stat file formats for very old kernel versions,
> which obscured key information that readers may find useful. Additionally,
> the example file contents and the reference to "15 fields" did not account
> for the flush fields added in b6866318657 ("block: add iostat counters for
> flush requests") [1].
>
> Rewrite the introduction to focus only on the current kernel's disk I/O stat
> file formats. Also, clean up wording for conciseness.
>
> Link: https://lore.kernel.org/lkml/157433282607.7928.5202409984272248322.stgit@buzz/T/ [1]
>
> Signed-off-by: David Reaver <me@davidreaver.com>
> ---
>
> Lore links to previous versions:
> V1: https://lore.kernel.org/linux-doc/20250214013905.60526-1-me@davidreaver.com/
> V2: https://lore.kernel.org/linux-doc/20250214051432.207630-1-me@davidreaver.com/
>
> Changes:
> V1 -> V2: Rewrite entire introduction instead of just changing 15 -> 17.
> V2 -> V3: Reword counter reset paragraph for accuracy and clarity.
>
> Documentation/admin-guide/iostats.rst | 89 ++++++++++-----------------
> 1 file changed, 33 insertions(+), 56 deletions(-)
This seems like a definite improvement at this point. Applied, thanks.
jn
prev parent reply other threads:[~2025-02-18 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-15 18:01 [PATCH v3] docs: iostats: Rewrite intro, remove outdated formats David Reaver
2025-02-16 8:46 ` Bagas Sanjaya
2025-02-18 20:30 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldu3ngh9.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=axboe@kernel.dk \
--cc=koct9i@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox