Re: [PATCH] FAT: use blkdev_issue_flush() instead of congestion_wait()

Christoph Hellwig
2021-11-17T10:52:26Z

On Wed, Nov 17, 2021 at 03:31:34PM +1100, NeilBrown wrote:
>
> congestion_wait() in this context is just a sleep - block devices do not
> in general support congestion signalling any more.
>
> The goal here is to wait for any recently written data to get to
> storage. This can be achieved using blkdev_issue_flush().

This goes back to commit ae78bf9c4f5fde3c67e2829505f195d7347ce3e4
and looking at that this seems to be correct. It might be worth to
reference that commit, though.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>