public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block: rnull: add missing MODULE_DESCRIPTION
@ 2024-11-30  9:45 ` FUJITA Tomonori
  2024-12-03 10:53   ` Andreas Hindborg
  2024-12-03 13:42   ` Jens Axboe
  0 siblings, 2 replies; 4+ messages in thread
From: FUJITA Tomonori @ 2024-11-30  9:45 UTC (permalink / raw)
  To: linux-block; +Cc: a.hindborg, boqun.feng, axboe, rust-for-linux

Add the missing description to fix the following warning:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/rnull_mod.o

Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
---
 drivers/block/rnull.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/rnull.rs b/drivers/block/rnull.rs
index 5de7223beb4d..9cca05dcf772 100644
--- a/drivers/block/rnull.rs
+++ b/drivers/block/rnull.rs
@@ -28,6 +28,7 @@
     type: NullBlkModule,
     name: "rnull_mod",
     author: "Andreas Hindborg",
+    description: "Rust implementation of the C null block driver",
     license: "GPL v2",
 }
 

base-commit: 2ba9f676d0a2e408aef14d679984c26373bf37b7
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: rnull: add missing MODULE_DESCRIPTION
  2024-11-30  9:45 ` [PATCH] block: rnull: add missing MODULE_DESCRIPTION FUJITA Tomonori
@ 2024-12-03 10:53   ` Andreas Hindborg
  2024-12-03 11:41     ` FUJITA Tomonori
  2024-12-03 13:42   ` Jens Axboe
  1 sibling, 1 reply; 4+ messages in thread
From: Andreas Hindborg @ 2024-12-03 10:53 UTC (permalink / raw)
  To: FUJITA Tomonori; +Cc: linux-block, boqun.feng, axboe, rust-for-linux

"FUJITA Tomonori" <fujita.tomonori@gmail.com> writes:

> Add the missing description to fix the following warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/rnull_mod.o
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>

Acked-by: Andreas Hindborg <a.hindborg@kernel.org>

Thanks for adding the description string. I am curious about the
warning, since I don't get it. Do I need to enable anything special to
get this warning?


Best regards,
Andreas Hindborg




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: rnull: add missing MODULE_DESCRIPTION
  2024-12-03 10:53   ` Andreas Hindborg
@ 2024-12-03 11:41     ` FUJITA Tomonori
  0 siblings, 0 replies; 4+ messages in thread
From: FUJITA Tomonori @ 2024-12-03 11:41 UTC (permalink / raw)
  To: a.hindborg
  Cc: fujita.tomonori, linux-block, boqun.feng, axboe, rust-for-linux

On Tue, 03 Dec 2024 11:53:41 +0100
Andreas Hindborg <a.hindborg@kernel.org> wrote:

>> Add the missing description to fix the following warning:
>>
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/rnull_mod.o
>>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
> 
> Acked-by: Andreas Hindborg <a.hindborg@kernel.org>
> 
> Thanks for adding the description string. I am curious about the
> warning, since I don't get it. Do I need to enable anything special to
> get this warning?

You just need to enable extra warnings, e.g., `make W=1`.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: rnull: add missing MODULE_DESCRIPTION
  2024-11-30  9:45 ` [PATCH] block: rnull: add missing MODULE_DESCRIPTION FUJITA Tomonori
  2024-12-03 10:53   ` Andreas Hindborg
@ 2024-12-03 13:42   ` Jens Axboe
  1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-12-03 13:42 UTC (permalink / raw)
  To: linux-block, FUJITA Tomonori; +Cc: a.hindborg, boqun.feng, rust-for-linux


On Sat, 30 Nov 2024 18:45:21 +0900, FUJITA Tomonori wrote:
> Add the missing description to fix the following warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/rnull_mod.o
> 
> 

Applied, thanks!

[1/1] block: rnull: add missing MODULE_DESCRIPTION
      (no commit info)

Best regards,
-- 
Jens Axboe




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-03 13:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <nxIB6ABobvhiDA2z5gk5pNpCwflPD7Faqf6s4WWaJseb8VIkFsYa2Vl3aeMLZyC0G2HecJ0D1_GPf3FczGjCww==@protonmail.internalid>
2024-11-30  9:45 ` [PATCH] block: rnull: add missing MODULE_DESCRIPTION FUJITA Tomonori
2024-12-03 10:53   ` Andreas Hindborg
2024-12-03 11:41     ` FUJITA Tomonori
2024-12-03 13:42   ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox