From: Andreas Hindborg <a.hindborg@kernel.org>
To: "Adrián García Casado" <adriangarciacasado42@gmail.com>,
"Jens Axboe" <axboe@kernel.dk>
Cc: "Boqun Feng" <boqun@kernel.org>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Adrián García Casado" <adriangarciacasado42@gmail.com>
Subject: Re: [PATCH v4] rust: block: rnull: update to Pin<KBox<QueueData>> for PinInit
Date: Wed, 18 Mar 2026 14:03:22 +0100 [thread overview]
Message-ID: <87qzphqoh1.fsf@kernel.org> (raw)
In-Reply-To: <20260317193257.13848-1-adriangarciacasado42@gmail.com>
Adrián García Casado <adriangarciacasado42@gmail.com> writes:
> Utilize the pin_init! macro for QueueData initialization to correctly support in-place initialization patterns. This aligns the driver with standard Rust-for-Linux pinning practices for driver-specific queue data.
>
> Signed-off-by: Adrián García Casado <adriangarciacasado42@gmailcom>
I don't understand the rationale for this patch. I already have a patch
on list that pins `QueueData` for rnull [1], but not for the reasons you
mention here. `QueueData` does not need to be pinned if it does not have
any fields of types that must always be pinned.
Best regards,
Andreas Hindborg
[1] https://lore.kernel.org/r/20260216-rnull-v6-19-rc5-send-v1-13-de9a7af4b469@kernel.org
prev parent reply other threads:[~2026-03-18 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2hK6oarCGyUX9gXNJ6wZZoePYLShXTYjw8wOlhbW1szik-km-pMO8wtX6dgm5i34HLG2zxzqZgK-cb2MiDtdpw==@protonmail.internalid>
2026-03-17 19:32 ` [PATCH v4] rust: block: rnull: update to Pin<KBox<QueueData>> for PinInit Adrián García Casado
2026-03-18 7:44 ` Benno Lossin
2026-03-18 13:03 ` Andreas Hindborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzphqoh1.fsf@kernel.org \
--to=a.hindborg@kernel.org \
--cc=adriangarciacasado42@gmail.com \
--cc=axboe@kernel.dk \
--cc=boqun@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox