From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kvalo@codeaurora.org>
From: Kalle Valo <kvalo@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kees Cook <keescook@chromium.org>,  Herbert Xu <herbert@gondor.apana.org.au>,  Arnd Bergmann <arnd@arndb.de>,  Eric Biggers <ebiggers@google.com>,  "Gustavo A. R. Silva" <gustavo@embeddedor.com>,  Alasdair Kergon <agk@redhat.com>,  Rabin Vincent <rabinv@axis.com>,  Tim Chen <tim.c.chen@linux.intel.com>,  "Rafael J. Wysocki" <rjw@rjwysocki.net>,  Pavel Machek <pavel@ucw.cz>,  Thomas Gleixner <tglx@linutronix.de>,  Ingo Molnar <mingo@redhat.com>,  "H. Peter Anvin" <hpa@zytor.com>,  x86@kernel.org,  Philipp Reisner <philipp.reisner@linbit.com>,  Lars Ellenberg <lars.ellenberg@linbit.com>,  Jens Axboe <axboe@kernel.dk>,  Giovanni Cabiddu <giovanni.cabiddu@intel.com>,  Mike Snitzer <snitzer@redhat.com>,  Paul Mackerras <paulus@samba.org>,  Greg Kroah-Hartman <gregkh@linuxfoundation.org>,  David Howells <dhowells@redhat.com>,  Tudor-Dan Ambarus <tudor.ambarus@microchip.com>,  Jia-Ju Bai <baijiaju1990@gmail.com>,  Andrew Morton <akpm@linux-foundation.org>,  Geert Uytterhoeven <geert@lin
 ux-m68k.org>,  Josh Poimboeuf <jpoimboe@redhat.com>,  David Woodhouse <dwmw@amazon.co.uk>,  Will Deacon <will.deacon@arm.com>,  dm-devel@redhat.com,  linux-pm@vger.kernel.org,  linux-crypto@vger.kernel.org,  drbd-dev@lists.linbit.com,  linux-block@vger.kernel.org,  qat-linux@intel.com,  linux-ppp@vger.kernel.org,  netdev@vger.kernel.org,  devel@driverdev.osuosl.org,  linux-afs@lists.infradead.org,  linux-wireless@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 13/18] wireless/lib80211: Convert from ahash to shash
References: <20180724164936.37477-1-keescook@chromium.org>
	<20180724164936.37477-14-keescook@chromium.org>
	<1532503493.3223.0.camel@sipsolutions.net>
Date: Wed, 25 Jul 2018 11:05:42 +0300
In-Reply-To: <1532503493.3223.0.camel@sipsolutions.net> (Johannes Berg's
	message of "Wed, 25 Jul 2018 09:24:53 +0200")
Message-ID: <87tvong2p5.fsf@purkki.adurom.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-ID: <linux-block@vger.kernel.org>

Johannes Berg <johannes@sipsolutions.net> writes:

> On Tue, 2018-07-24 at 09:49 -0700, Kees Cook wrote:
>> In preparing to remove all stack VLA usage from the kernel[1], this
>> removes the discouraged use of AHASH_REQUEST_ON_STACK in favor of
>> the smaller SHASH_DESC_ON_STACK by converting from ahash-wrapped-shash
>> to direct shash. By removing a layer of indirection this both improves
>> performance and reduces stack usage. The stack allocation will be made
>> a fixed size in a later patch to the crypto subsystem.
>
> I think you sent this before - it should be in net-next now.

Yup, I see it in net-next:

d17504b16ea2 wireless/lib80211: Convert from ahash to shash

-- 
Kalle Valo