[PATCH blktests] loop/009: require --option of udevadm control command

[PATCH blktests] loop/009: require --option of udevadm control command

[Shin'ichiro Kawasaki]

The test case loop/009 calls udevadm control command with --ping option.
When systemd version is prior to 241, udevadm control command does not
support the option, and the test case fails. Check availability of the
option to avoid the failure.

Link: https://github.com/osandov/blktests/issues/129
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/loop/009 | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/loop/009 b/tests/loop/009
index 2b7a042..5c14758 100755
--- a/tests/loop/009
+++ b/tests/loop/009
@@ -10,6 +10,12 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
 
 QUICK=1
 
+requires() {
+	if ! udevadm control --ping > /dev/null 2>&1; then
+		SKIP_REASONS+=("udevadm control does not support --ping option")
+	fi
+}
+
 test() {
 	echo "Running ${TEST_NAME}"
 
-- 
2.43.0

Re: [PATCH blktests] loop/009: require --option of udevadm control command

[Disha Goel]

On 29/11/23 5:06 pm, Shin'ichiro Kawasaki wrote:

> The test case loop/009 calls udevadm control command with --ping option.
> When systemd version is prior to 241, udevadm control command does not
> support the option, and the test case fails. Check availability of the
> option to avoid the failure.
>
> Link: https://github.com/osandov/blktests/issues/129
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

Thanks for the fix patch. I have tested on Power10 machine, loop/009 test skips with patch applied.

# ./check loop/009
loop/009 (check that LOOP_CONFIGURE sends uevents for partitions) [not run]
runtime  0.481s  ...
udevadm control does not support --ping option


Feel free to add:
Reported-by and Tested-by: Disha Goel <disgoel@linux.ibm.com>

> ---
>   tests/loop/009 | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/loop/009 b/tests/loop/009
> index 2b7a042..5c14758 100755
> --- a/tests/loop/009
> +++ b/tests/loop/009
> @@ -10,6 +10,12 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
>   
>   QUICK=1
>   
> +requires() {
> +	if ! udevadm control --ping > /dev/null 2>&1; then
> +		SKIP_REASONS+=("udevadm control does not support --ping option")
> +	fi
> +}
> +
>   test() {
>   	echo "Running ${TEST_NAME}"
>   

Re: [PATCH blktests] loop/009: require --option of udevadm control command

[Alyssa Ross]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com> writes:

> The test case loop/009 calls udevadm control command with --ping option.
> When systemd version is prior to 241, udevadm control command does not
> support the option, and the test case fails. Check availability of the
> option to avoid the failure.
>
> Link: https://github.com/osandov/blktests/issues/129
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

Reviewed-by: Alyssa Ross <hi@alyssa.is>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH blktests] loop/009: require --option of udevadm control command

[Bart Van Assche]

On 11/29/23 03:36, Shin'ichiro Kawasaki wrote:
> The test case loop/009 calls udevadm control command with --ping option.
> When systemd version is prior to 241, udevadm control command does not
> support the option, and the test case fails. Check availability of the
> option to avoid the failure.
> 
> Link: https://github.com/osandov/blktests/issues/129
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>   tests/loop/009 | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/loop/009 b/tests/loop/009
> index 2b7a042..5c14758 100755
> --- a/tests/loop/009
> +++ b/tests/loop/009
> @@ -10,6 +10,12 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
>   
>   QUICK=1
>   
> +requires() {
> +	if ! udevadm control --ping > /dev/null 2>&1; then
> +		SKIP_REASONS+=("udevadm control does not support --ping option")
> +	fi
> +}
> +
>   test() {
>   	echo "Running ${TEST_NAME}"
>   

Hmm ... why "> /dev/null 2>&1" instead of the shorter ">&/dev/null"?

Thanks,

Bart.

Re: [PATCH blktests] loop/009: require --option of udevadm control command

[Shinichiro Kawasaki]

On Nov 29, 2023 / 09:59, Bart Van Assche wrote:
> On 11/29/23 03:36, Shin'ichiro Kawasaki wrote:
> > The test case loop/009 calls udevadm control command with --ping option.
> > When systemd version is prior to 241, udevadm control command does not
> > support the option, and the test case fails. Check availability of the
> > option to avoid the failure.
> > 
> > Link: https://github.com/osandov/blktests/issues/129
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> > ---
> >   tests/loop/009 | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/tests/loop/009 b/tests/loop/009
> > index 2b7a042..5c14758 100755
> > --- a/tests/loop/009
> > +++ b/tests/loop/009
> > @@ -10,6 +10,12 @@ DESCRIPTION="check that LOOP_CONFIGURE sends uevents for partitions"
> >   QUICK=1
> > +requires() {
> > +	if ! udevadm control --ping > /dev/null 2>&1; then
> > +		SKIP_REASONS+=("udevadm control does not support --ping option")
> > +	fi
> > +}
> > +
> >   test() {
> >   	echo "Running ${TEST_NAME}"
> 
> Hmm ... why "> /dev/null 2>&1" instead of the shorter ">&/dev/null"?

No reason :) I will fold in the shorter one to the commit. Thanks.

Re: [PATCH blktests] loop/009: require --option of udevadm control command

[Shinichiro Kawasaki]

On Nov 29, 2023 / 20:36, Shin'ichiro Kawasaki wrote:
> The test case loop/009 calls udevadm control command with --ping option.
> When systemd version is prior to 241, udevadm control command does not
> support the option, and the test case fails. Check availability of the
> option to avoid the failure.
> 
> Link: https://github.com/osandov/blktests/issues/129
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

Thanks for the comments. I've applied this with the fix suggested.