linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <tom.leiming@gmail.com>,
	linux-block <linux-block@vger.kernel.org>,
	kernel@collabora.com
Subject: Re: [PATCH v2] block: Consider only dispatched requests for inflight statistic
Date: Tue, 15 Sep 2020 12:11:12 -0400	[thread overview]
Message-ID: <87wo0vj9zz.fsf@collabora.com> (raw)
In-Reply-To: <87r1rkorsf.fsf_-_@collabora.com> (Gabriel Krisman Bertazi's message of "Wed, 02 Sep 2020 16:19:28 -0400")

Gabriel Krisman Bertazi <krisman@collabora.com> writes:

> Jens Axboe <axboe@kernel.dk> writes:
>
>> We just need to decide if this makes sense or not. I think we should
>> apply this for 5.10, with Ming's suggestion of using
>> blk_mq_request_started(). Then I guess we'll see what happens...
>
> Hello,
>
> Here is the second version, then.  But, instead of
> blk_mq_request_started as suggested on the review, this uses
> blk_mq_rq_state to access the state attribute, since we don't want to
> include MQ_RQ_COMPLETE.
>
> Also, improved the commit message a bit.
>

Hi Jens,

Sorry for the ping.  Have you made a decision here?

Thanks,

-- 
Gabriel Krisman Bertazi

      reply	other threads:[~2020-09-15 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 15:31 [PATCH] block: Fix inflight statistic for MQ submission with !elevator Gabriel Krisman Bertazi
2020-08-31 15:33 ` Jens Axboe
2020-08-31 15:50   ` Gabriel Krisman Bertazi
2020-09-01  1:18 ` Ming Lei
2020-09-01  3:42   ` Jens Axboe
2020-09-01  6:36     ` Ming Lei
2020-09-01 22:37       ` Jens Axboe
2020-09-01 18:37   ` Gabriel Krisman Bertazi
2020-09-01 22:39     ` Jens Axboe
2020-09-02 20:19       ` [PATCH v2] block: Consider only dispatched requests for inflight statistic Gabriel Krisman Bertazi
2020-09-15 16:11         ` Gabriel Krisman Bertazi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wo0vj9zz.fsf@collabora.com \
    --to=krisman@collabora.com \
    --cc=axboe@kernel.dk \
    --cc=kernel@collabora.com \
    --cc=linux-block@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).