Re: [PATCH 2/4] block: factor out a bio_await helper

[Damien Le Moal <dlemoal@kernel.org>]

On 2026/04/06 7:57, Christoph Hellwig wrote:
> Add a new helper to wait for a bio and anything chained off it to
> complete synchronous after kicking it.  This factors common code out

s/synchronous after kicking it/synchronously after submitting it

(kicking is a little confusing as it could mean "rejecting")

> of submit_bio_wait and bio_await_chain and will also be useful for
> file system code and thus is exported.
> 
> Note that this will now set REQ_SYNC also for the bio_await case for
> consistency.  Nothing should look at the flag in the end_io handler,
> but if did, having the flag set makes more sense.

s/if did/if something does ?

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  block/bio.c         | 53 +++++++++++++++++++++++++++++++--------------
>  include/linux/bio.h |  2 ++
>  2 files changed, 39 insertions(+), 16 deletions(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 434e41182c05..c7e75d532666 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1468,17 +1468,20 @@ static void bio_wait_end_io(struct bio *bio)
>  }
>  
>  /**
> - * submit_bio_wait - submit a bio, and wait until it completes
> - * @bio: The &struct bio which describes the I/O
> + * bio_await - call a function on a bio, and wait until it completes
> + * @bio:	the bio which describes the I/O
> + * @kick:	function called to "kick off" the bio

To be consistent with my comment above, I think a better (clearer) name her
would be simply "submit".

Other than these nits, looks all good to me. So feel free to add:

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research