From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E5DC433F5 for ; Tue, 15 Feb 2022 02:29:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233595AbiBOCaE (ORCPT ); Mon, 14 Feb 2022 21:30:04 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbiBOCaE (ORCPT ); Mon, 14 Feb 2022 21:30:04 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E068ADFD6; Mon, 14 Feb 2022 18:29:54 -0800 (PST) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JyQ4v3RVjzcccZ; Tue, 15 Feb 2022 10:28:47 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 10:29:52 +0800 Received: from [10.174.179.5] (10.174.179.5) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Feb 2022 10:29:52 +0800 Subject: Re: [RFC PATCH] blk-mq: avoid housekeeping CPUs scheduling a worker on a non-housekeeping CPU To: , , CC: , , , References: <20220210093532.182818-1-wangxiongfeng2@huawei.com> From: Xiongfeng Wang Message-ID: <881ae7a8-5dff-ff50-9bc2-a983b6a53c30@huawei.com> Date: Tue, 15 Feb 2022 10:29:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20220210093532.182818-1-wangxiongfeng2@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.5] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Ming, Sorry to disturb you. It's just that I think you may be interested at this patch. I found the following commit written by you. commit 11ea68f553e244851d15793a7fa33a97c46d8271 genirq, sched/isolation: Isolate from handling managed interrupts It removed the managed_irq interruption from non-housekeeping CPUs as long as the non-housekeeping CPUs do not request IO. But the the work thread blk_mq_run_work_fn() may still run on the non-housekeeping CPUs. Appreciate it a lot if you can give it a look. Thanks, Xiongfeng On 2022/2/10 17:35, Xiongfeng Wang wrote: > When NOHZ_FULL is enabled, such as in HPC situation, CPUs are divided > into housekeeping CPUs and non-housekeeping CPUs. Non-housekeeping CPUs > are NOHZ_FULL CPUs and are often monopolized by the userspace process, > such HPC application process. Any sort of interruption is not expected. > > blk_mq_hctx_next_cpu() selects each cpu in 'hctx->cpumask' alternately > to schedule the work thread blk_mq_run_work_fn(). When 'hctx->cpumask' > contains housekeeping CPU and non-housekeeping CPU at the same time, a > housekeeping CPU, which want to request a IO, may schedule a worker on a > non-housekeeping CPU. This may affect the performance of the userspace > application running on non-housekeeping CPUs. > > So let's just schedule the worker thread on the current CPU when the > current CPU is housekeeping CPU. > > Signed-off-by: Xiongfeng Wang > --- > block/blk-mq.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 1adfe4824ef5..ff9a4bf16858 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2036,6 +2037,8 @@ static int blk_mq_hctx_next_cpu(struct blk_mq_hw_ctx *hctx) > static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async, > unsigned long msecs) > { > + int work_cpu; > + > if (unlikely(blk_mq_hctx_stopped(hctx))) > return; > > @@ -2050,7 +2053,17 @@ static void __blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async, > put_cpu(); > } > > - kblockd_mod_delayed_work_on(blk_mq_hctx_next_cpu(hctx), &hctx->run_work, > + /* > + * Avoid housekeeping CPUs scheduling a worker on a non-housekeeping > + * CPU > + */ > + if (tick_nohz_full_enabled() && housekeeping_cpu(smp_processor_id(), > + HK_FLAG_WQ)) > + work_cpu = smp_processor_id(); > + else > + work_cpu = blk_mq_hctx_next_cpu(hctx); > + > + kblockd_mod_delayed_work_on(work_cpu, &hctx->run_work, > msecs_to_jiffies(msecs)); > } > >