From: Rolf Fokkens <rolf@rolffokkens.nl>
To: Coly Li <colyli@suse.de>, linux-bcache@vger.kernel.org
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
Nix <nix@esperi.org.uk>, Pierre JUHEN <pierre.juhen@orange.fr>,
linux-block@vger.kernel.org
Subject: Re: [RFC PATCH] bcache: fix stack corruption by PRECEDING_KEY()
Date: Sat, 8 Jun 2019 20:50:30 +0200 [thread overview]
Message-ID: <8855017f-729e-9719-236d-e98710702564@rolffokkens.nl> (raw)
In-Reply-To: <20190608102204.60126-1-colyli@suse.de>
On 6/8/19 12:22 PM, Coly Li wrote:
> +static inline void preceding_key(struct bkey *k, struct bkey *preceding_key_p)
> +{
> + if (KEY_INODE(k) || KEY_OFFSET(k)) {
> + *preceding_key_p = KEY(KEY_INODE(k), KEY_OFFSET(k), 0);
> + if (!preceding_key_p->low)
> + preceding_key_p->high--;
> + preceding_key_p->low--;
> + } else {
> + preceding_key_p = NULL;
If I'm correct, the line above has no net effect, it just changes a
local variable (parameter) with no effect elsewhere. So the else part
may be left out, or do you mean this?
*preceding_key_p = ZERO_KEY;
> + }
> +}
>
> static inline bool bch_ptr_invalid(struct btree_keys *b, const struct bkey *k)
> {
next prev parent reply other threads:[~2019-06-08 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 10:22 [RFC PATCH] bcache: fix stack corruption by PRECEDING_KEY() Coly Li
2019-06-08 18:50 ` Rolf Fokkens [this message]
2019-06-08 21:52 ` Pierre JUHEN
2019-06-09 0:59 ` Coly Li
2019-06-09 5:56 ` Pierre JUHEN
2019-06-09 8:23 ` Coly Li
2019-06-09 9:21 ` Coly Li
2019-06-09 10:46 ` Pierre JUHEN
2019-06-09 12:16 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8855017f-729e-9719-236d-e98710702564@rolffokkens.nl \
--to=rolf@rolffokkens.nl \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=pierre.juhen@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox