Linux block layer
 help / color / mirror / Atom feed
From: Sahil Chandna <chandna.linuxkernel@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: fix EOD return for device with nr_sectors == 0
Date: Mon, 22 Sep 2025 19:18:11 +0530	[thread overview]
Message-ID: <898a2fff-54a0-461b-84b9-07c08e6d1f9e@gmail.com> (raw)
In-Reply-To: <855243b5-1226-47d5-9ca8-c023209f5ee7@kernel.dk>



On 9/22/25 5:28 PM, Jens Axboe wrote:
> A recent commit skipped dumping the usual "attempt to access beyond end
> of device" message if the device size is 0 sectors, as that's a common
> pattern for devices that have been hot removed. But while it stopped
> that message, it also prevented returning -EIO for that condition.
> Reinstate the -EIO return, while retaining the quiet operation for
> triggering EOD for a device with 0 sectors.
> 
> Reported-by: syzbot+4b12286339fe4c2700c1@syzkaller.appspotmail.com
> Reported-by: Sahil Chandna <chandna.linuxkernel@gmail.com>
> Fixes: d0a2b527d8c3 ("block: tone down bio_check_eod")
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> 
> ---
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 4201504158a1..a27185cd8ede 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -557,9 +557,11 @@ static inline int bio_check_eod(struct bio *bio)
>   	sector_t maxsector = bdev_nr_sectors(bio->bi_bdev);
>   	unsigned int nr_sectors = bio_sectors(bio);
>   
> -	if (nr_sectors && maxsector &&
> +	if (nr_sectors &&
>   	    (nr_sectors > maxsector ||
>   	     bio->bi_iter.bi_sector > maxsector - nr_sectors)) {
> +		if (!maxsector)
> +			return -EIO;
>   		pr_info_ratelimited("%s: attempt to access beyond end of device\n"
>   				    "%pg: rw=%d, sector=%llu, nr_sectors = %u limit=%llu\n",
>   				    current->comm, bio->bi_bdev, bio->bi_opf,
> 
Hi,
I tested the patch and it *does not* reproduce the original syzkaller 
bug [1].
Tested-by: Sahil Chandna <chandna.linuxkernel@gmail.com>

[1] https://syzkaller.appspot.com./bug?extid=4b12286339fe4c2700c1

  reply	other threads:[~2025-09-22 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 11:58 [PATCH] block: fix EOD return for device with nr_sectors == 0 Jens Axboe
2025-09-22 13:48 ` Sahil Chandna [this message]
2025-09-22 15:35   ` Jens Axboe
2025-09-22 16:57 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=898a2fff-54a0-461b-84b9-07c08e6d1f9e@gmail.com \
    --to=chandna.linuxkernel@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox