public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	Omar Sandoval <osandov@osandov.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-xfs@vger.kernel.org, sandeen@sandeen.net,
	Omar Sandoval <osandov@fb.com>,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize
Date: Tue, 5 Sep 2017 09:00:26 -0600	[thread overview]
Message-ID: <89dbce28-5798-f404-4dc8-a85aae36cdec@kernel.dk> (raw)
In-Reply-To: <2656563.n056MvCHVb@localhost.localdomain>

On 09/05/2017 01:37 AM, Chandan Rajendra wrote:
> On Tuesday, September 5, 2017 12:12:08 PM IST Omar Sandoval wrote:
>> On Mon, Sep 04, 2017 at 11:31:39PM -0700, Christoph Hellwig wrote:
>>> On Tue, Sep 05, 2017 at 11:14:42AM +0530, Chandan Rajendra wrote:
>>>> Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set
>>>> physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default
>>>> physical sector size of loop devices. On ppc64, this causes loop devices
>>>> to have 64k as the physical sector size.
>>>
>>> Eek.  We'll need to revert the loop change ASAP!
>>
>> Most annoying patch series ever. It hasn't made it to Linus' tree yet,
>> right? We can revert (although the later change depends on that), fold
>> in a fix, or apply a fix on top of it, whatever Jens prefers.
>>
>>
> 
> My bad. 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 is the commit id from 
> Linux-next. I don't see this commit in Linus's git tree.

Right, it's only queued up, and scheduled for the 2nd part of the
block changes for 4.14. It should have been PAGE_CACHE_SIZE, but
we don't have that anymore...

Omar, are you sending a patch to fix this up?

-- 
Jens Axboe

  reply	other threads:[~2017-09-05 15:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170905054442.28615-1-chandan@linux.vnet.ibm.com>
2017-09-05  6:31 ` [PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize Christoph Hellwig
2017-09-05  6:42   ` Omar Sandoval
2017-09-05  7:37     ` Chandan Rajendra
2017-09-05 15:00       ` Jens Axboe [this message]
2017-09-05 22:06         ` Dave Chinner
2017-09-05 22:18           ` Omar Sandoval
2017-09-05 23:24             ` Dave Chinner
2017-09-06  0:01               ` Omar Sandoval
2017-09-05  6:44   ` Dave Chinner
2017-09-05 14:17     ` Eric Sandeen
2017-09-05 22:10       ` Dave Chinner
2017-09-05 22:16         ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89dbce28-5798-f404-4dc8-a85aae36cdec@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=osandov@fb.com \
    --cc=osandov@osandov.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox