From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC35C38142 for ; Fri, 27 Jan 2023 07:03:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232211AbjA0HDK (ORCPT ); Fri, 27 Jan 2023 02:03:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232299AbjA0HC6 (ORCPT ); Fri, 27 Jan 2023 02:02:58 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85CF9DBC2; Thu, 26 Jan 2023 23:02:51 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1953621CA3; Fri, 27 Jan 2023 07:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674802970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEqWCahipqJW4d7agZGVcQVF7iiP+fmVIvrNVbtdtTE=; b=yyKD+ewTh/51wAJ4yeE2HQ2M5DTaA3gbhHhqbnsHb/L9Rlal6NYix10LxOxtd6iinyZSWW vnHv3nF40kfnsK31kZbAYg+dUnp8yD+ysfj8rtRVUUNVH5iuIWNfpt9/6a8Lbkpw4DxXCm iybWn1XubVwWl22ItfFlqwH2Qi+Q+Xo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674802970; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEqWCahipqJW4d7agZGVcQVF7iiP+fmVIvrNVbtdtTE=; b=eoYfXxcKKQEY+eclwtBbcr3YwyEin8a6Kfa8woNZG1eSrGhSq4X7zVtR26JoOYoVePRpsE V1V4GLplUQ8dXcCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F17041336F; Fri, 27 Jan 2023 07:02:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yNJpOhl302OqUgAAMHmgww (envelope-from ); Fri, 27 Jan 2023 07:02:49 +0000 Message-ID: <89fc8cdf-1faf-6f67-ff12-78405d434d69@suse.de> Date: Fri, 27 Jan 2023 08:02:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 04/15] blk-cgroup: pin the gendisk in struct blkcg_gq Content-Language: en-US To: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org References: <20230117081257.3089859-1-hch@lst.de> <20230117081257.3089859-5-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230117081257.3089859-5-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 1/17/23 09:12, Christoph Hellwig wrote: > Currently each blkcg_gq holds a request_queue reference, which is what > is used in the policies. But a lot of these interface will move over to > use a gendisk, so store a disk in strut blkcg_gq and hold a reference to > it. > > Signed-off-by: Christoph Hellwig > --- > block/bfq-cgroup.c | 6 +++--- > block/blk-cgroup-rwstat.c | 2 +- > block/blk-cgroup.c | 29 +++++++++++++---------------- > block/blk-cgroup.h | 11 +++++------ > block/blk-iocost.c | 2 +- > block/blk-iolatency.c | 4 ++-- > block/blk-throttle.c | 4 ++-- > 7 files changed, 27 insertions(+), 31 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman