From: Jens Axboe <axboe@kernel.dk>
To: Omar Sandoval <osandov@osandov.com>, Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org, stable@vger.kernel.org,
Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH V4] blk-mq: avoid to starve tag allocation after allocation process migrates
Date: Thu, 24 May 2018 10:53:37 -0600 [thread overview]
Message-ID: <8aaf8f1d-9b5b-0b4c-d374-efbdf2c125ba@kernel.dk> (raw)
In-Reply-To: <20180524165216.GG12533@vader>
On 5/24/18 10:52 AM, Omar Sandoval wrote:
> On Thu, May 24, 2018 at 03:49:10PM +0800, Ming Lei wrote:
>> When the allocation process is scheduled back and the mapped hw queue is
>> changed, fake one extra wake up on previous queue for compensating wake up
>> miss, so other allocations on the previous queue won't be starved.
>>
>> This patch fixes one request allocation hang issue, which can be
>> triggered easily in case of very low nr_request.
>>
>> Cc: <stable@vger.kernel.org>
>> Cc: Omar Sandoval <osandov@fb.com>
>
> Reviewed-by: Omar Sandoval <osandov@fb.com>
>
> The longer explanation you gave would be nice to have in the commit
> message, but maybe Jens can add that when he applies it.
Exactly, I had planned on augmenting the commit message since I don't
think the above really explains it. I'll do that and get it applied.
--
Jens Axboe
prev parent reply other threads:[~2018-05-24 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 7:49 [PATCH V4] blk-mq: avoid to starve tag allocation after allocation process migrates Ming Lei
2018-05-24 16:52 ` Omar Sandoval
2018-05-24 16:53 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aaf8f1d-9b5b-0b4c-d374-efbdf2c125ba@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox