From: Jens Axboe <axboe@kernel.dk>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Ming Lei <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH V2] null_blk: allow zero poll queues
Date: Thu, 23 Dec 2021 17:55:32 -0700 [thread overview]
Message-ID: <8b1f05d7-c741-24e3-be67-bf3616ff1931@kernel.dk> (raw)
In-Reply-To: <20211224005237.ryuyjrrn63t7y7sa@shindev>
On 12/23/21 5:52 PM, Shinichiro Kawasaki wrote:
> On Dec 03, 2021 / 21:09, Ming Lei wrote:
>> There isn't any reason to not allow zero poll queues from user
>> viewpoint.
>>
>> Also sometimes we need to compare io poll between poll mode and irq
>> mode, so not allowing poll queues is bad.
>>
>> Fixes: 15dfc662ef31 ("null_blk: Fix handling of submit_queues and poll_queues attributes")
>> Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>> Signed-off-by: Ming Lei <ming.lei@redhat.com>
>> ---
>> V2:
>> - fix divide zero fault as reported by Shin'ichiro
>
> Jens, Ming,
>
> I find the V1 was applied to the for/5.17-drivers branch, and the additional fix
> in the V2 does not look applied to the branch. Do we need another small patch to
> cover the delta between V1 and V2?
Yes, please send an incremental, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-12-24 0:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 13:09 [PATCH V2] null_blk: allow zero poll queues Ming Lei
2021-12-04 1:35 ` Shinichiro Kawasaki
2021-12-24 0:52 ` Shinichiro Kawasaki
2021-12-24 0:55 ` Jens Axboe [this message]
2021-12-24 4:32 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b1f05d7-c741-24e3-be67-bf3616ff1931@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox