From: Jens Axboe <axboe@kernel.dk>
To: Yufen Yu <yuyufen@huawei.com>, dan.carpenter@oracle.com
Cc: linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] floppy: check_events callback should not return a negative number
Date: Tue, 12 Feb 2019 09:13:29 -0700 [thread overview]
Message-ID: <8bf64920-f0fe-b9da-8759-0d05a0fa39e0@kernel.dk> (raw)
In-Reply-To: <20190129083404.47318-1-yuyufen@huawei.com>
On 1/29/19 1:34 AM, Yufen Yu wrote:
> floppy_check_events() is supposed to return bit flags to say which
> events occured. We should return zero to say that no event flags are
> set. Only BIT(0) and BIT(1) are used in the caller. And .check_events
> interface also expect to return an unsigned int value.
>
> However, after commit a0c80efe5956, it may return -EINTR (-4u).
> Here, both BIT(0) and BIT(1) are cleared. So this patch shouldn't
> affect runtime, but it obviously is still worth fixing.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-02-12 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 8:34 [PATCH v2] floppy: check_events callback should not return a negative number Yufen Yu
2019-01-29 8:41 ` Dan Carpenter
2019-02-12 10:50 ` yuyufen
2019-02-12 16:13 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf64920-f0fe-b9da-8759-0d05a0fa39e0@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox