public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: John Pittman <jpittman@redhat.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer
Date: Wed, 14 Feb 2018 19:03:44 -0700	[thread overview]
Message-ID: <8c4f1f22-223e-6bc1-6261-dceb0caf5219@kernel.dk> (raw)
In-Reply-To: <1518658622-5931-1-git-send-email-jpittman@redhat.com>

On 2/14/18 6:37 PM, John Pittman wrote:
> In quite a few files throughout the block layer, the bare 'unsigned' is
> used rather than the preferred 'unsigned int'.  The issue was
> exposed by checkpatch.pl.  Warnings encountered were:
> 
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>     WARNING: Prefer 'unsigned int *' to bare use of 'unsigned *'
> 
> Fixed 64 total warnings.

I'm not going to take this, unless there's a specific bug related
to it.

-- 
Jens Axboe

  reply	other threads:[~2018-02-15  2:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15  1:37 [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer John Pittman
2018-02-15  2:03 ` Jens Axboe [this message]
2018-02-15  2:13 ` Al Viro
2018-02-15  2:26   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c4f1f22-223e-6bc1-6261-dceb0caf5219@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=jpittman@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox