Linux block layer
 help / color / mirror / Atom feed
From: Philipp Stanner <phasta@mailbox.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
	axboe@kernel.dk,  andriy.shevchenko@linux.intel.com,
	phasta@kernel.org, fourier.thomas@gmail.com,
	 viro@zeniv.linux.org.uk, martin.petersen@oracle.com
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Fix typos in comments and log messages
Date: Mon, 13 Oct 2025 09:34:24 +0200	[thread overview]
Message-ID: <8d3bf7c232248d4d8fd5e1f032c8e3d56c9e50ac.camel@mailbox.org> (raw)
In-Reply-To: <20251012184010.198891-1-alok.a.tiwari@oracle.com>

On Sun, 2025-10-12 at 11:40 -0700, Alok Tiwari wrote:
> This patch corrects several minor typos and spelling errors in mtip32xx.c
> - Fixing "ge" -> "get" in a warning message.
> - Correcting "kernrel" -> "kernel", "progess" -> "progress"
>   "strucutre" -> "structure" in comments.

btw. I think listing such examples in the commit message for a mere
typo fix patch is a bit overkill; but of course not harmful.

> 
> no functional impact.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>

Reviewed-by: Philipp Stanner <phasta@kernel.org>

> ---
>  drivers/block/mtip32xx/mtip32xx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 567192e371a8..df184a9f006f 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -1337,7 +1337,7 @@ static int mtip_get_smart_attr(struct mtip_port *port, unsigned int id,
>  	memset(port->smart_buf, 0, ATA_SECT_SIZE);
>  	rv = mtip_get_smart_data(port, port->smart_buf, port->smart_buf_dma);
>  	if (rv) {
> -		dev_warn(&port->dd->pdev->dev, "Failed to ge SMART data\n");
> +		dev_warn(&port->dd->pdev->dev, "Failed to get SMART data\n");

One could think of adding a full stop '.'

Although the kernel is quite inconsistent with these anyways.

>  		return rv;
>  	}
>  
> @@ -2127,7 +2127,7 @@ static int mtip_hw_submit_io(struct driver_data *dd, struct request *rq,
>  /*
>   * Sysfs status dump.
>   *
> - * @dev  Pointer to the device structure, passed by the kernrel.
> + * @dev  Pointer to the device structure, passed by the kernel.
>   * @attr Pointer to the device_attribute structure passed by the kernel.
>   * @buf  Pointer to the char buffer that will receive the stats info.
>   *
> @@ -2679,7 +2679,7 @@ static int mtip_hw_get_identify(struct driver_data *dd)
>  		}
>  	}
>  
> -	/* get write protect progess */
> +	/* get write protect progress */
>  	memset(&attr242, 0, sizeof(struct smart_attr));
>  	if (mtip_get_smart_attr(dd->port, 242, &attr242))
>  		dev_warn(&dd->pdev->dev,
> @@ -3148,7 +3148,7 @@ static int mtip_block_compat_ioctl(struct block_device *dev,
>   * that each partition is also 4KB aligned. Non-aligned partitions adversely
>   * affects performance.
>   *
> - * @disk Pointer to the gendisk strucutre.
> + * @disk Pointer to the gendisk structure.
>   * @geo Pointer to a hd_geometry structure.
>   *
>   * return value


  reply	other threads:[~2025-10-13  7:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-12 18:40 [PATCH] block: mtip32xx: Fix typos in comments and log messages Alok Tiwari
2025-10-13  7:34 ` Philipp Stanner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-18 19:18 Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d3bf7c232248d4d8fd5e1f032c8e3d56c9e50ac.camel@mailbox.org \
    --to=phasta@mailbox.org \
    --cc=alok.a.tiwari@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=fourier.thomas@gmail.com \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=phasta@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox