From: Pavel Begunkov <asml.silence@gmail.com>
To: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 5/6] block: move three bvec helpers declaration into private helper
Date: Mon, 11 Jan 2021 04:42:45 +0000 [thread overview]
Message-ID: <8d8eb758-072c-4f98-4cda-65a26aa3eaec@gmail.com> (raw)
In-Reply-To: <20210111030557.4154161-6-ming.lei@redhat.com>
On 11/01/2021 03:05, Ming Lei wrote:
> bvec_alloc(), bvec_free() and bvec_nr_vecs() are only used inside block
> layer core functions, no need to declare them in public header.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> block/blk.h | 4 ++++
> include/linux/bio.h | 3 ---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/block/blk.h b/block/blk.h
> index 7550364c326c..a21a35c4a3e4 100644
> --- a/block/blk.h
> +++ b/block/blk.h
> @@ -55,6 +55,10 @@ void blk_free_flush_queue(struct blk_flush_queue *q);
>
> void blk_freeze_queue(struct request_queue *q);
>
> +struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
> +void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
> +unsigned int bvec_nr_vecs(unsigned short idx);
> +
> static inline bool biovec_phys_mergeable(struct request_queue *q,
> struct bio_vec *vec1, struct bio_vec *vec2)
> {
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index f606eb1e556f..70914dd6a70d 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -478,9 +478,6 @@ static inline void zero_fill_bio(struct bio *bio)
> zero_fill_bio_iter(bio, bio->bi_iter);
> }
>
> -extern struct bio_vec *bvec_alloc(gfp_t, int, unsigned long *, mempool_t *);
> -extern void bvec_free(mempool_t *, struct bio_vec *, unsigned int);
> -extern unsigned int bvec_nr_vecs(unsigned short idx);
> extern const char *bio_devname(struct bio *bio, char *buffer);
>
> #define bio_set_dev(bio, bdev) \
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-11 4:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 3:05 [PATCH V3 0/6] block: improvement on bioset & bvec allocation Ming Lei
2021-01-11 3:05 ` [PATCH V3 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-11 4:39 ` Pavel Begunkov
2021-01-11 6:57 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-11 4:41 ` Pavel Begunkov
2021-01-11 6:57 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Ming Lei
2021-01-11 4:41 ` Pavel Begunkov
2021-01-11 6:58 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 4/6] block: set .bi_max_vecs as actual allocated vector number Ming Lei
2021-01-11 4:42 ` Pavel Begunkov
2021-01-11 6:59 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-11 4:42 ` Pavel Begunkov [this message]
2021-01-11 7:00 ` Hannes Reinecke
2021-01-11 3:05 ` [PATCH V3 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei
2021-01-11 3:54 ` Coly Li
2021-01-11 7:00 ` Hannes Reinecke
2021-01-11 4:35 ` [PATCH V3 0/6] block: improvement on bioset & bvec allocation Pavel Begunkov
2021-01-25 2:27 ` Ming Lei
2021-01-25 4:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d8eb758-072c-4f98-4cda-65a26aa3eaec@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox