From: Bart Van Assche <bvanassche@acm.org>
To: Damien Le Moal <dlemoal@kernel.org>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>
Subject: Re: [PATCH 4/5] block: add tracepoint for blkdev_zone_mgmt
Date: Thu, 10 Jul 2025 08:46:29 -0700 [thread overview]
Message-ID: <8e23a43d-4f86-451f-a7db-a88325d4abeb@acm.org> (raw)
In-Reply-To: <6443646a-fb74-44dd-b15d-ea37929e3c79@kernel.org>
On 7/9/25 9:10 PM, Damien Le Moal wrote:
> On 7/10/25 12:37 AM, Bart Van Assche wrote:
>> On 7/9/25 4:47 AM, Johannes Thumshirn wrote:
>>> + TP_printk("%d,%d %s %llu + %llu",
>>> + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->rwbs,
>>> + (unsigned long long)__entry->sector,
>>> + __entry->nr_sectors)
>>
>> sector_t is a synonym for u64. u64 is defined as unsigned long in
>> include/uapi/asm-generic/int-l64.h and is defined as unsigned long long
>> in include/uapi/asm-generic/int-ll64.h. Kernel code always includes
>> the int-ll64.h header file. In other words, I think the above cast is
>> superfluous for all CPU architectures supported by the Linux kernel.
>
> %llu format will not work on 32-bits arch.
Huh? I think it would be a severe bug in the code in lib/vsprintf.c if
it would not support the %llu format on 32-bits architectures. Is there
perhaps a misunderstanding?
Bart.
next prev parent reply other threads:[~2025-07-10 15:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 11:46 [PATCH 0/5] block: add tracepoints for ZBD specific operations Johannes Thumshirn
2025-07-09 11:47 ` [PATCH 1/5] blktrace: add zoned block commands to blk_fill_rwbs Johannes Thumshirn
2025-07-09 15:30 ` Bart Van Assche
2025-07-10 5:55 ` Johannes Thumshirn
2025-07-10 15:48 ` Bart Van Assche
2025-07-14 10:23 ` Johannes Thumshirn
2025-07-14 16:00 ` Bart Van Assche
2025-07-10 4:13 ` Damien Le Moal
2025-07-10 9:59 ` Johannes Thumshirn
2025-07-10 10:39 ` Damien Le Moal
2025-07-09 11:47 ` [PATCH 2/5] block: split blk_zone_update_request_bio into two functions Johannes Thumshirn
2025-07-10 4:15 ` Damien Le Moal
2025-07-09 11:47 ` [PATCH 3/5] block: add tracepoint for blk_zone_update_request_bio Johannes Thumshirn
2025-07-10 4:18 ` Damien Le Moal
2025-07-09 11:47 ` [PATCH 4/5] block: add tracepoint for blkdev_zone_mgmt Johannes Thumshirn
2025-07-09 15:37 ` Bart Van Assche
2025-07-10 4:10 ` Damien Le Moal
2025-07-10 15:46 ` Bart Van Assche [this message]
2025-07-10 4:20 ` Damien Le Moal
2025-07-09 11:47 ` [PATCH 5/5] block: add trace messages to zone write plugging Johannes Thumshirn
2025-07-10 4:23 ` Damien Le Moal
2025-07-10 6:27 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e23a43d-4f86-451f-a7db-a88325d4abeb@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).