From: Bart Van Assche <bart.vanassche@wdc.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros
Date: Mon, 22 Jan 2018 08:33:37 -0800 [thread overview]
Message-ID: <8ecbf7d2-b056-cd93-ebf3-b4eaf22f7abe@wdc.com> (raw)
In-Reply-To: <20180122075348.6974-1-jthumshirn@suse.de>
On 01/21/18 23:53, Johannes Thumshirn wrote:
> - dprintk("map hdr %llx/%u %llx/%u\n", (unsigned long long) hdr->dout_xferp,
> + pr_debug("map hdr %llx/%u %llx/%u\n",
> + (unsigned long long) hdr->dout_xferp,
> hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
> hdr->din_xfer_len);
Should the indentation of the arguments have been adjusted?
> @@ -299,7 +292,7 @@ static void bsg_rq_end_io(struct request *rq, blk_status_t status)
> struct bsg_device *bd = bc->bd;
> unsigned long flags;
>
> - dprintk("%s: finished rq %p bc %p, bio %p\n",
> + pr_debug("%s: finished rq %p bc %p, bio %p\n",
> bd->name, rq, bc, bc->bio);
Same question here ...
Thanks,
Bart.
next prev parent reply other threads:[~2018-01-22 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:53 [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros Johannes Thumshirn
2018-01-22 16:33 ` Bart Van Assche [this message]
2018-01-22 20:23 ` Joe Perches
2018-01-22 20:42 ` Bart Van Assche
2018-01-22 21:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ecbf7d2-b056-cd93-ebf3-b4eaf22f7abe@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox