From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: blk-rq-qos: guard rq-qos helpers by static key
Date: Tue, 15 Apr 2025 15:37:30 +0000 [thread overview]
Message-ID: <8f68fe7a-c8c1-438a-a9d5-7dbadd1f0872@nvidia.com> (raw)
In-Reply-To: <ee26d050-dd58-4672-93c2-d5b3fa63bbae@kernel.dk>
On 4/15/25 07:52, Jens Axboe wrote:
> Even if blk-rq-qos isn't used or configured, dipping into the queue to
> fetch ->rq_qos is a noticeable slowdown and visible in profiles. Add an
> unlikely static key around blk-rq-qos, to avoid fetching this cacheline
> if blk-iolatency or blk-wbt isn't configured or used.
>
> Signed-off-by: Jens Axboe<axboe@kernel.dk>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2025-04-15 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 14:52 [PATCH] block: blk-rq-qos: guard rq-qos helpers by static key Jens Axboe
2025-04-15 15:37 ` Chaitanya Kulkarni [this message]
2025-04-17 11:08 ` Yu Kuai
2025-04-17 12:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f68fe7a-c8c1-438a-a9d5-7dbadd1f0872@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox