From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <kch@nvidia.com>, linux-block@vger.kernel.org
Cc: damien.lemoal@opensource.wdc.com, johannes.thumshirn@wdc.com,
bvanassche@acm.org, kbusch@kernel.org, vincent.fu@samsung.com,
shinichiro.kawasaki@wdc.com, error27@gmail.com
Subject: Re: [PATCH 0/4] null_blk: usr memcpy_[to|from]_page()
Date: Wed, 29 Mar 2023 16:48:03 -0600 [thread overview]
Message-ID: <8f759010-cd5e-3ace-9b6e-ea4f896ee789@kernel.dk> (raw)
In-Reply-To: <20230329204652.52785-1-kch@nvidia.com>
On 3/29/23 2:46 PM, Chaitanya Kulkarni wrote:
> Hi,
>
> From :include/linux/highmem.h:
> "kmap_atomic - Atomically map a page for temporary usage - Deprecated!"
>
> Use memcpy_from_page() since does the same job of mapping, copying, and
> unmaping except it uses non deprecated kmap_local_page() and
> kunmap_local(). Following are the differences between kmal_local_page()
> and kmap_atomic() :-
Looks fine to me, but I'd fold patches 1-3 rather than split them up.
--
Jens Axboe
next prev parent reply other threads:[~2023-03-29 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 20:46 [PATCH 0/4] null_blk: usr memcpy_[to|from]_page() Chaitanya Kulkarni
2023-03-29 20:46 ` [PATCH 1/4] null_blk: use memcpy_page() in copy_to_nullb() Chaitanya Kulkarni
2023-03-29 20:46 ` [PATCH 2/4] null_blk: use memcpy_page() in copy_from_nullb() Chaitanya Kulkarni
2023-03-29 20:46 ` [PATCH 3/4] null-blk: use memset_page() to fill page pattern Chaitanya Kulkarni
2023-03-29 20:46 ` [PATCH 4/4] null_blk: use kmap_local_page() and kunmap_local() Chaitanya Kulkarni
2023-03-29 22:48 ` Jens Axboe [this message]
2023-03-30 18:56 ` [PATCH 0/4] null_blk: usr memcpy_[to|from]_page() Chaitanya Kulkarni
2023-03-30 23:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f759010-cd5e-3ace-9b6e-ea4f896ee789@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=error27@gmail.com \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox