From: Jens Axboe <axboe@kernel.dk>
To: Zhou Chengming <zhouchengming1@huawei.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
miaoxie@huawei.com
Subject: Re: [PATCH v3] don't forget to call pd_online_fn when activate policy
Date: Sat, 11 Mar 2017 15:25:30 -0700 [thread overview]
Message-ID: <8f877e5c-4ceb-7c6e-c44b-c6ca3a72a5f1@kernel.dk> (raw)
In-Reply-To: <1489203980-46134-1-git-send-email-zhouchengming1@huawei.com>
On 03/10/2017 08:46 PM, Zhou Chengming wrote:
> When we activate policy on the request_queue, we will create policy_date
> for all the existing blkgs of the request_queue, so we should call
> pd_init_fn() and pd_online_fn() on these newly created policy_data.
I'm not looking at this until you tell me that you have runtime
tested it. I'm assuming you originally ran into some issue
with the lack of calling pd_online_fn?
--
Jens Axboe
prev parent reply other threads:[~2017-03-11 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 3:46 [PATCH v3] don't forget to call pd_online_fn when activate policy Zhou Chengming
2017-03-11 22:25 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f877e5c-4ceb-7c6e-c44b-c6ca3a72a5f1@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox