From: Jens Axboe <axboe@kernel.dk>
To: Michael Lyle <mlyle@lyle.org>,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, stable@vger.kernel.org
Subject: Re: [PATCH] bio: ensure __bio_clone_fast copies bi_partno
Date: Fri, 17 Nov 2017 08:27:40 -0700 [thread overview]
Message-ID: <8f93b1dd-9909-a9be-28d1-a10e4f06bdd7@kernel.dk> (raw)
In-Reply-To: <20171117074725.22536-1-mlyle@lyle.org>
On 11/17/2017 12:47 AM, Michael Lyle wrote:
> A new field was introduced in 74d46992e0d9dee7f1f376de0d56d31614c8a17a,
> bi_partno, instead of using bdev->bd_contains and encoding the partition
> information in the bi_bdev field. __bio_clone_fast was changed to copy
> the disk information, but not the partition information. At minimum,
> this regressed bcache and caused data corruption.
That's not good... Fix looks good to me, I'll queue this up for a pull
today. Thanks for bisecting this, Michael.
--
Jens Axboe
next prev parent reply other threads:[~2017-11-17 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 7:47 [PATCH] bio: ensure __bio_clone_fast copies bi_partno Michael Lyle
2017-11-17 11:04 ` Coly Li
2017-11-17 11:34 ` Ming Lei
2017-11-17 15:08 ` Christoph Hellwig
2017-11-17 15:27 ` Jens Axboe [this message]
2017-11-17 16:50 ` Bart Van Assche
2017-11-17 17:02 ` Michael Lyle
2017-11-17 17:18 ` hch
2017-11-17 20:25 ` Campbell Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f93b1dd-9909-a9be-28d1-a10e4f06bdd7@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).