From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Block changes for 5.15-rc1
Date: Mon, 30 Aug 2021 20:06:38 -0600 [thread overview]
Message-ID: <90ecd1a6-c7e2-8899-15c4-57183380b63c@kernel.dk> (raw)
In-Reply-To: <CAHk-=whbPcDsJqKoW1HO_8c=FCUGhOifDR+tUpdt4bALAgtTJA@mail.gmail.com>
On 8/30/21 7:56 PM, Linus Torvalds wrote:
> On Mon, Aug 30, 2021 at 7:32 AM Jens Axboe <axboe@kernel.dk> wrote:
>>
>> 2) drivers/block/virtio_blk.c - error handling fix later in the 5.14
>> cycle ends up touching the same out path. My resolution:
>>
>> - goto out_cleanup_disk;
>> ++ goto err_cleanup_disk;
> ..
>> -out_cleanup_disk:
>> +err_cleanup_disk:
>
> I did it the other way, and used "out_cleanup_disk" to match all the
> other "out_xyz" cases in that function..
>
> That should obviously be equivalent, unless something strange is going on.
Yeah that's totally fine, and it's funny because that is how I did it
the other times too. When sending this out, not sure why it ended up
differently. I do think out_* is the right choice, matches the other
ones.
--
Jens Axboe
next prev parent reply other threads:[~2021-08-31 2:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 14:32 [GIT PULL] Block changes for 5.15-rc1 Jens Axboe
2021-08-31 1:56 ` Linus Torvalds
2021-08-31 2:06 ` Jens Axboe [this message]
2021-08-31 2:14 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90ecd1a6-c7e2-8899-15c4-57183380b63c@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox