Linux block layer
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Daniel Wagner <dwagner@suse.de>
Cc: shinichiro.kawasaki@wdc.com, linux-block@vger.kernel.org,
	hch@lst.de, linux-nvme@lists.infradead.org,
	John Garry <john.garry@linux.dev>
Subject: Re: [PATCH blktests] nvme/069: add a test for multipath cdev lifetime
Date: Wed, 15 Jul 2026 14:19:59 +0100	[thread overview]
Message-ID: <92c3a0d8-d85b-440d-8277-2dd75aebda28@oracle.com> (raw)
In-Reply-To: <7f5c5f13-78a1-4d66-bdc4-e2e2260dd949@flourine.local>

On 15/07/2026 13:20, Daniel Wagner wrote:
> On Tue, Jul 14, 2026 at 09: 43: 45AM +0000, John Garry wrote: > + # nvme-delay-
> ioctl will open the nvme-generic cdev, sleep, and then > + # issue an ioctl. > +
> # We tear down the nvme-subsystem in the foreground so we can catch > +
> 
> 
> On Tue, Jul 14, 2026 at 09:43:45AM +0000, John Garry wrote:
>> +	# nvme-delay-ioctl will open the nvme-generic cdev, sleep, and then
>> +	# issue an ioctl.
>> +	# We tear down the nvme-subsystem in the foreground so we can catch
>> +	# if the ioctl triggers a use-after-free KASAN warn.
>> +	src/nvme-delay-ioctl "/dev/$nvmegeneric" &
>> +	sleep 0.5
>> +	_nvme_disconnect_ctrl "${nvmedev}"
> 
> The sleep above is to give nvme-delay-ioctl enough time to setup,
> right? 

Right

> Would it possible for nvme-delay-ioctl issue some signal (or any
> other working sync method) and we just wait for it to show up? IMO sleep
> should be avoided if possible.

I suppose we could do something like nvme-delay-ioctl writing to a file, 
which we can poll. Or use a signal.

Let me investigate.

John

      reply	other threads:[~2026-07-15 13:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  9:43 [PATCH blktests] nvme/069: add a test for multipath cdev lifetime John Garry
2026-07-15 12:20 ` Daniel Wagner
2026-07-15 13:19   ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92c3a0d8-d85b-440d-8277-2dd75aebda28@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=john.garry@linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox