From: Jens Axboe <axboe@kernel.dk>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org
Subject: Re: add error handling to add_disk / device_add_disk
Date: Mon, 23 Aug 2021 13:50:14 -0600 [thread overview]
Message-ID: <9345b22b-b8b8-6e2d-4ebb-2cd96bbd52f7@kernel.dk> (raw)
In-Reply-To: <YSP6uZOYQ6kX+B+3@bombadil.infradead.org>
On 8/23/21 1:44 PM, Luis Chamberlain wrote:
> On Mon, Aug 23, 2021 at 12:57:41PM -0600, Jens Axboe wrote:
>> On 8/18/21 8:45 AM, Christoph Hellwig wrote:
>>> Hi Jens,
>>>
>>> this series does some refactoring and then adds support to return errors
>>> from add_disk (rebasing a patch from Luis). I think that alone is a huge
>>> improvement as it leaves a disk for which add_disk failed in a defined
>>> status, but the real improvement will be actually handling the errors in
>>> the drivers. This series contains two trivial conversions. Luis has
>>> a tree with conversions for all drivers in the tree, which will be fed
>>> incrementally once this goes in. Hopefully we can convert all the
>>> commonly used drivers in this merge window.
>>
>> Applied, thanks.
>
> Do you have a branch published which has this by any chance? I checked
> but can't see anything obvious.
It's in the core branch, just hadn't been pushed out yet. Now it is,
find it in for-5.15/block
--
Jens Axboe
prev parent reply other threads:[~2021-08-23 19:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 14:45 add error handling to add_disk / device_add_disk Christoph Hellwig
2021-08-18 14:45 ` [PATCH 01/11] block: add a sanity check for a live disk in del_gendisk Christoph Hellwig
2021-08-19 10:41 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 02/11] block: fold register_disk into device_add_disk Christoph Hellwig
2021-08-19 10:48 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 03/11] block: call bdev_add later in device_add_disk Christoph Hellwig
2021-08-20 6:06 ` Hannes Reinecke
2025-10-31 7:46 ` question about bd_inode hashing against device_add() // " Gao Xiang
2025-10-31 9:09 ` Christoph Hellwig
2025-10-31 9:36 ` Gao Xiang
2025-10-31 9:45 ` Christoph Hellwig
2025-10-31 9:54 ` Gao Xiang
2025-10-31 9:58 ` Greg Kroah-Hartman
2025-10-31 10:12 ` Gao Xiang
2025-10-31 12:23 ` Gao Xiang
2025-10-31 12:25 ` Gao Xiang
2025-10-31 14:34 ` Greg Kroah-Hartman
2025-10-31 14:44 ` Gao Xiang
2025-11-05 3:04 ` Gao Xiang
2025-11-05 12:30 ` Christian Brauner
2025-11-05 14:13 ` Gao Xiang
2025-10-31 14:31 ` Greg Kroah-Hartman
2025-10-31 14:40 ` Gao Xiang
2021-08-18 14:45 ` [PATCH 04/11] block: create the bdi link earlier " Christoph Hellwig
2021-08-20 6:08 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 05/11] block: call blk_integrity_add " Christoph Hellwig
2021-08-20 6:08 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 06/11] block: call blk_register_queue " Christoph Hellwig
2021-08-20 6:09 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 07/11] block: return errors from blk_integrity_add Christoph Hellwig
2021-08-20 6:10 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 08/11] block: return errors from disk_alloc_events Christoph Hellwig
2021-08-20 6:10 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 09/11] block: add error handling for device_add_disk / add_disk Christoph Hellwig
2021-08-20 6:12 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 10/11] virtio_blk: add error handling support for add_disk() Christoph Hellwig
2021-08-20 6:12 ` Hannes Reinecke
2021-08-18 14:45 ` [PATCH 11/11] null_blk: " Christoph Hellwig
2021-08-20 6:13 ` Hannes Reinecke
2021-08-23 18:57 ` add error handling to add_disk / device_add_disk Jens Axboe
2021-08-23 19:44 ` Luis Chamberlain
2021-08-23 19:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9345b22b-b8b8-6e2d-4ebb-2cd96bbd52f7@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox