From: Cengiz Can <cengiz@kernel.wtf>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jens Axboe <axboe@kernel.dk>, Ingo Molnar <mingo@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blktrace: fix dereference after null check
Date: Wed, 04 Mar 2020 14:07:17 +0300 [thread overview]
Message-ID: <950cfb6c63a0ab33ff2b4bb33cfa3567@kernel.wtf> (raw)
In-Reply-To: <20200303091436.2e7ab191@gandalf.local.home>
On 2020-03-03 17:14, Steven Rostedt wrote:
>
> Note, you should probably add a note in your change log that this issue
> was
> found by Coverity. Sometimes static analyzers have a tag of some kind
> that
> they would like patches that fix the issues they discover to be in the
> change log. This way they can track the fixes that are found by the
> tool.
>
I have added the Coverity issue ID and relevant notes to mark it.
Thanks.
>
> As I said in the other email, the above assignment still needs RCU
> annotation:
>
> bt = rcu_dereference_protected(q->blk_trace,
> lockdep_is_held(&q->blk_trace_mutex));
I missed that. Thanks for reminding. TIL.
Please check PATCH-v2.
--
Cengiz Can
@cengiz_io
prev parent reply other threads:[~2020-03-04 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 7:33 [PATCH] blktrace: fix dereference after null check Cengiz Can
2020-03-03 13:29 ` Bob Liu
2020-03-03 13:35 ` Steven Rostedt
2020-03-03 13:44 ` Bob Liu
2020-03-03 14:14 ` Steven Rostedt
2020-03-04 11:07 ` Cengiz Can [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=950cfb6c63a0ab33ff2b4bb33cfa3567@kernel.wtf \
--to=cengiz@kernel.wtf \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).