From: Bart Van Assche <bvanassche@acm.org>
To: Ye Bin <yebin@huaweicloud.com>,
axboe@kernel.dk, linux-block@vger.kernel.org
Cc: ming.lei@redhat.com
Subject: Re: [PATCH 2/2] block/mq-deadline: add module parameter for prio_aging_expire default
Date: Thu, 20 Aug 2026 08:54:48 -0700 [thread overview]
Message-ID: <954f42ce-fbb9-4c51-a6de-198aa18797c5@acm.org> (raw)
In-Reply-To: <20260820021246.2681624-3-yebin@huaweicloud.com>
On 8/19/26 7:12 PM, Ye Bin wrote:
> -static const int prio_aging_expire = 10 * HZ;
> +static int prio_aging_expire = 10 * MSEC_PER_SEC;
> +module_param(prio_aging_expire, int, 0644);
> +MODULE_PARM_DESC(prio_aging_expire,
> + "Default prio_aging_expire in milliseconds; 0 disables I/O priority.");
Disabling I/O priority support by setting prio_aging_expire is ugly
and probably will confuse users. There must be better solutions.
Bart.
prev parent reply other threads:[~2026-08-20 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 2:12 [PATCH 0/2] disable I/O priority when prio_aging_expire is zero Ye Bin
2026-08-20 2:12 ` [PATCH 1/2] block/mq-deadline: " Ye Bin
2026-08-20 15:31 ` Bart Van Assche
2026-08-21 2:06 ` yebin
2026-08-21 17:22 ` Bart Van Assche
2026-08-20 2:12 ` [PATCH 2/2] block/mq-deadline: add module parameter for prio_aging_expire default Ye Bin
2026-08-20 15:54 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=954f42ce-fbb9-4c51-a6de-198aa18797c5@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yebin@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox