From: Jens Axboe <axboe@kernel.dk>
To: Wenwen Wang <wang6495@umn.edu>, Wenwen Wang <wenwen@cs.uga.edu>
Cc: "open list:BLOCK LAYER" <linux-block@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] block/bio-integrity: fix a memory leak bug
Date: Thu, 11 Jul 2019 20:02:10 -0600 [thread overview]
Message-ID: <956286e2-06fc-4d43-e78e-8f2059292aab@kernel.dk> (raw)
In-Reply-To: <1562872923-2463-1-git-send-email-wang6495@umn.edu>
On 7/11/19 1:22 PM, Wenwen Wang wrote:
> From: Wenwen Wang <wenwen@cs.uga.edu>
>
> In bio_integrity_prep(), a kernel buffer is allocated through kmalloc() to
> hold integrity metadata. Later on, the buffer will be attached to the bio
> structure through bio_integrity_add_page(), which returns the number of
> bytes of integrity metadata attached. Due to unexpected situations,
> bio_integrity_add_page() may return 0. As a result, bio_integrity_prep()
> needs to be terminated with 'false' returned to indicate this error.
> However, the allocated kernel buffer is not freed on this execution path,
> leading to a memory leak.
>
> To fix this issue, free the allocated buffer before returning from
> bio_integrity_prep().
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-07-12 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 19:22 [PATCH v2] block/bio-integrity: fix a memory leak bug Wenwen Wang
2019-07-12 0:33 ` Ming Lei
2019-07-12 1:10 ` Martin K. Petersen
2019-07-12 2:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=956286e2-06fc-4d43-e78e-8f2059292aab@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang6495@umn.edu \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).