From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58898433059 for ; Mon, 24 Aug 2026 13:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787579942; cv=none; b=S+TTYmvCOUJ2SC1cVlzf6J/vExCycg08L8x43mtC2E0DCJ7UU7tdc/COQnXty6tKW3xK5JjGUGXmO19YWs2u27EXG9gcfaNEF0HqkEozd93B9Iu0kXQJy2qD4xwABzyPj0OL3oQWI2ADMnGr2cgo312J3SbpS9Jt3ZWAlNIoiHk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787579942; c=relaxed/simple; bh=VyXPha22ahQxc4HIlWxvGyHCTBNhScu/VLpt/eHz32A=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=VcWsqPabtm3wAcesn/bqt3sdek9gCOlrZCh+mu39L3EbvnUReo01OEuS62a8A4JlGLKe79WAH84DCQ4zhJR4LqOsQwOMYMvVkK+efC2FSgD0OemrwlVKZ8Tuwe6NCLj0EjZ2yuH7QNbhO5s6KJRytLcSWebWa7V7l7+y6/1SNjA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EFNBQcft; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EFNBQcft" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-66c744a00edso2126778d50.2 for ; Mon, 24 Aug 2026 06:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787579940; x=1788184740; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8DePtEtd6bTjy8gbPPUEJydq7WmfU3cohWIB8nVvJ4g=; b=EFNBQcftqm3mUxQIObkidigTaDAlKV7NioBcsr6/HJ/6XySrMXtY0aI4mbeNkNC2gZ BBY3gb0o1DKjAcMAE/mq+uxnsfL55YIg7SQLA8tg+ObId46P1xR+I7f3M9vXrCXo6z9F fN7LxcHgSQDb/L6LCZbq/Y0NvwzcKRU/TVcsssudYspXWq1EznzHpxnm9edhZzIVtW2n iBJxUkRowhpuWMAC/r03p9cuCxHiGIuvjWdXuLfN5ch3nyhrUxPXWMOcIXdz98/UH8mQ EIH4FFWeveO5cluEDLxFm0z9keEAqarc+nc4DZEeVREAPeYYLUqxiuGJzG5qIL5Y2FC+ hezg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787579940; x=1788184740; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8DePtEtd6bTjy8gbPPUEJydq7WmfU3cohWIB8nVvJ4g=; b=S1Q2iSY37mLOvLIf4FUDQiIlajayedzTA2MbLIrqwKlmkoQqZvMPeZNc5usTaTMiNF 9feH2Ua8ZSU+I6WQ+5+ezGGMyAZkhIqCnp7B77YurWGj8Ro+H14EQgAdi3+PxIdYIo2v hSTZvpQufQXcrpvWccqn1SmaBmaoVz84b9FmgjMzvAOkuoTveuf1OET821x2lLFFoJLw H5oBrNtvKF9fI+9I+RizbsvzSYxbZolgjcePOdNWw/QCcRaP7flHmc1XEh7OFKZbBUuP 4eKTXnTY++W6GlBJvAFxaP9tRIike8eDxu/M90o8cy0onOTo3F6lVe4XO65zeN+0E57A GlLw== X-Forwarded-Encrypted: i=1; AHgh+RpeXt5s5vPxZROEyyIbzjvciGdQ/M+GAdD9sPTqVW+OJwtWbThc7vOPSu5HioPgVIZe6ALSzHW51cZCzg==@vger.kernel.org X-Gm-Message-State: AFuF++lk/WcCl1k1IQdR8he+LcGx38z8fc8wrw/JTuU+XYLFRR7uRdi7 A6ztiwtCKuwm67Q+zqP2X82BSk7VpXwhewgP9tNAjE+Z0S2OA2rckT9JaIpOCZRSFw== X-Gm-Gg: AR+sD10YGs//z7hnNFUoCpgw6g0AiIY3FajJ2/z+8ZvlOYzN6N5O+Tt8e/4IQNf4OPX nUNMDegyTpb+dfZ6cR/F7YG7rISRk66120+hCuE4B1or47RhNCh0Z/i8LYLxRVmmph8bXlD3Vfb Hb9nZcY6VpSQ5xgB1K5s1JYxvI+QQNi3NRLoMolgsxLGnaBxtBl4l4Gf0YqfIZmlWNQ4JwFa8Q8 8a/GDLOZsQPSjnZZjFHyWQ945M9MQN0FMInc0gDRX4/FIqKMELWfygtF9RRK2osA11HeKjEHx2S 7JkP5hniC1mSpGLkuM0LFj0o6cz1qbiGR7KvAFYqKU7Jd2vwhmWu5sG+TMevBTLzhxSQVmnu0dC B5pIiGpx2H8M7rjp6demRUdY+Xs7S4h7Lq6SH47R5Asq7LM1Vf389Pz0RYCsV78FL3MIAD6mOas yZ4noTMhm4e5KYdrTCJlMLVl7qNa+XRdRkUziuf1c1g8gc2czVwWD96YCSuEJXuW+jw9tu7dGmu KYkfOArmyKtJ81LIscKTkpw8Vh3xVVomIbqoYBwa8WTLdLKTJBUa/eIIEI= X-Received: by 2002:a53:ac9c:0:b0:66c:fb45:77e2 with SMTP id 956f58d0204a3-66cfb457872mr3574386d50.28.1787579939500; Mon, 24 Aug 2026 06:58:59 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84ca68c1b14sm34163727b3.21.2026.08.24.06.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 06:58:58 -0700 (PDT) Date: Mon, 24 Aug 2026 06:58:54 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 03/25] mm/fbatch: temporarily disable lazyfree and mlock+munlock batching In-Reply-To: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Message-ID: <9593975e-8732-999a-73d1-37fd332eb840@google.com> References: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII It will not matter if we occasionally get activation or deactivation wrong; but a mistaken lazyfree (MADV_FREE) would likely cause dataloss. So disable its batching while reworking the per-cpu fbatch handling, then re-enable it with more thought afterwards. Similarly disable mlock+munlock batching temporarily: they will need some redesign before re-enabling. Just insert one disabling line for now, leaving the rest of the code as it was, for consideration later. Signed-off-by: Hugh Dickins --- mm/folio.c | 2 ++ mm/mlock.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/mm/folio.c b/mm/folio.c index b2bce6b77498..a7010ae3edff 100644 --- a/mm/folio.c +++ b/mm/folio.c @@ -218,6 +218,8 @@ static void __folio_batch_add_and_move(struct folio_batch __percpu *fbatch, local_lock(&cpu_fbatches.lock); if (!folio_batch_add(this_cpu_ptr(fbatch), folio) || + /* XXX Temporarily disable lazyfree batching */ + fbatch == &cpu_fbatches.lru_lazyfree || !folio_may_be_lru_cached(folio) || lru_cache_disabled()) folio_batch_move_lru(this_cpu_ptr(fbatch), move_fn); diff --git a/mm/mlock.c b/mm/mlock.c index efa6716e4dfb..14c02e155d68 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -255,6 +255,7 @@ void mlock_folio(struct folio *folio) folio_get(folio); if (!folio_batch_add(fbatch, mlock_lru(folio)) || + true || /* XXX Temporarily disable mlock batching */ !folio_may_be_lru_cached(folio) || lru_cache_disabled()) mlock_folio_batch(fbatch); local_unlock(&mlock_fbatch.lock); @@ -278,6 +279,7 @@ void mlock_new_folio(struct folio *folio) folio_get(folio); if (!folio_batch_add(fbatch, mlock_new(folio)) || + true || /* XXX Temporarily disable mlock_new batching */ !folio_may_be_lru_cached(folio) || lru_cache_disabled()) mlock_folio_batch(fbatch); local_unlock(&mlock_fbatch.lock); @@ -299,6 +301,7 @@ void munlock_folio(struct folio *folio) */ folio_get(folio); if (!folio_batch_add(fbatch, folio) || + true || /* XXX Temporarily disable munlock batching */ !folio_may_be_lru_cached(folio) || lru_cache_disabled()) mlock_folio_batch(fbatch); local_unlock(&mlock_fbatch.lock); -- 2.51.0