From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B08CC33CA1 for ; Mon, 20 Jan 2020 10:17:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B8752073A for ; Mon, 20 Jan 2020 10:17:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgATKRp (ORCPT ); Mon, 20 Jan 2020 05:17:45 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:2284 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726621AbgATKRp (ORCPT ); Mon, 20 Jan 2020 05:17:45 -0500 Received: from lhreml705-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 430547EA414141BA4666; Mon, 20 Jan 2020 10:17:43 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by lhreml705-cah.china.huawei.com (10.201.108.46) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 Jan 2020 10:17:42 +0000 Received: from [127.0.0.1] (10.202.226.43) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 20 Jan 2020 10:17:42 +0000 Subject: Re: [PATCH 2/6] scsi: remove .for_blk_mq To: Ming Lei , James Bottomley , , "Martin K . Petersen" CC: , Jens Axboe , "Sathya Prakash" , Chaitra P B , Suganath Prabu Subramani , Kashyap Desai , Sumit Saxena , Shivasharan S , "Ewan D . Milne" , Christoph Hellwig , Hannes Reinecke , Bart Van Assche , Jason Yan References: <20200119071432.18558-1-ming.lei@redhat.com> <20200119071432.18558-3-ming.lei@redhat.com> From: John Garry Message-ID: <95a902c4-287a-eb23-dc5f-d3a66dff2289@huawei.com> Date: Mon, 20 Jan 2020 10:17:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200119071432.18558-3-ming.lei@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.43] X-ClientProxiedBy: lhreml718-chm.china.huawei.com (10.201.108.69) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 19/01/2020 07:14, Ming Lei wrote: > No one use it any more, so remove the flag. > > Cc: Sathya Prakash > Cc: Chaitra P B > Cc: Suganath Prabu Subramani > Cc: Kashyap Desai > Cc: Sumit Saxena > Cc: Shivasharan S > Cc: Ewan D. Milne > Cc: Christoph Hellwig , > Cc: Hannes Reinecke > Cc: Bart Van Assche > Signed-off-by: Ming Lei I think that we can also delete drivers/scsi/scsi.c:scsi_use_blk_mq. IIRC, a patch was already sent for that but never picked up. Thanks, John > --- > drivers/scsi/virtio_scsi.c | 1 - > include/scsi/scsi_host.h | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c > index bfec84aacd90..0e0910c5b942 100644 > --- a/drivers/scsi/virtio_scsi.c > +++ b/drivers/scsi/virtio_scsi.c > @@ -742,7 +742,6 @@ static struct scsi_host_template virtscsi_host_template = { > .dma_boundary = UINT_MAX, > .map_queues = virtscsi_map_queues, > .track_queue_depth = 1, > - .force_blk_mq = 1, > }; > > #define virtscsi_config_get(vdev, fld) \ > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index f577647bf5f2..7a97fb8104cf 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -426,9 +426,6 @@ struct scsi_host_template { > /* True if the controller does not support WRITE SAME */ > unsigned no_write_same:1; > > - /* True if the low-level driver supports blk-mq only */ > - unsigned force_blk_mq:1; > - > /* > * Countdown for host blocking with no commands outstanding. > */ >