From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F40AC4363D for ; Wed, 23 Sep 2020 06:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBD9821D43 for ; Wed, 23 Sep 2020 06:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbgIWGq3 (ORCPT ); Wed, 23 Sep 2020 02:46:29 -0400 Received: from mx2.suse.de ([195.135.220.15]:50572 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726179AbgIWGq3 (ORCPT ); Wed, 23 Sep 2020 02:46:29 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 54261B00D; Wed, 23 Sep 2020 06:47:04 +0000 (UTC) Subject: Re: [PATCH V3 for 5.11 09/12] scsi: put hot fields of scsi_host_template into one cacheline To: Ming Lei , Jens Axboe , linux-block@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: Omar Sandoval , Kashyap Desai , Sumanesh Samanta , "Ewan D . Milne" , Christoph Hellwig References: <20200923013339.1621784-1-ming.lei@redhat.com> <20200923013339.1621784-10-ming.lei@redhat.com> From: Hannes Reinecke Message-ID: <9629d3c1-61df-8816-5676-2788176b2b77@suse.de> Date: Wed, 23 Sep 2020 08:46:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200923013339.1621784-10-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 9/23/20 3:33 AM, Ming Lei wrote: > The following three fields of scsi_host_template are referenced in > scsi IO submission path, so put them together into one cacheline: > > - cmd_size > - queuecommand > - commit_rqs > > Cc: Omar Sandoval > Cc: Kashyap Desai > Cc: Sumanesh Samanta > Cc: Ewan D. Milne > Cc: Hannes Reinecke > Reviewed-by: Christoph Hellwig > Signed-off-by: Ming Lei > --- > include/scsi/scsi_host.h | 72 ++++++++++++++++++++++------------------ > 1 file changed, 39 insertions(+), 33 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer