From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F7DC433E0 for ; Tue, 11 Aug 2020 13:13:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 94B252083B for ; Tue, 11 Aug 2020 13:13:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="jdu0KZuJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728720AbgHKNNi (ORCPT ); Tue, 11 Aug 2020 09:13:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728557AbgHKNNh (ORCPT ); Tue, 11 Aug 2020 09:13:37 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43CD2C06174A for ; Tue, 11 Aug 2020 06:13:37 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id 2so1850368pjx.5 for ; Tue, 11 Aug 2020 06:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xHu6dqtx6dKHdWpQM9ecfqF6ipS8+Ftc0J6RvgUhGFo=; b=jdu0KZuJGN7BSi/GvbU8wDgSr5m6NHgobmXY0Qa1UBkL9hhJdh1tM2Mx4P2/3dVILb JoF/CaxgNxTO5fYriU7q2WXbHY81dQTzL3qkVbxu9CSNR9bTc3h3CZBdIoJCholq/cPJ JbLEmEqnnFP8eK740tBfhUFK/G1xlAAvI9pXJNVS5UJaOQ6I7cqkvOmXmlEIVBvJWVuV ASLxte1F5dhJdr+bjcvf3xh1jNQh2tRI7rhlFZg/jeqZ9DdjDtQaZm7I9uQ63uy+tpyL oOiiywQjZbLvS4l79qQLLu7Ty6KBAZHSaxxhh+1CmwEfdTtaQeHpNV6MQ7toYOR2kOli Y8Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xHu6dqtx6dKHdWpQM9ecfqF6ipS8+Ftc0J6RvgUhGFo=; b=ZD5w8gVgFe8+JbD1cVic4ZwcEDab+udHHiJE9ZCgZByPP6EnzVazOE/0X7GCLxH7u0 SvXZPrn69IfjMsOnX9uqDY38ljEmrolI97ybm3UEQUGPGMhGP4wf8SRAyOipli1VXmyD WffHGwxgUbAKE8zVcyRRFk9DL8A1RGq0Mdr/kRrZeE778AQ0WCXe3qXiq+sNs2HBIOZA hrBPD9d9B671CU6P9NN1h9WRSEj5eb7/dJROGYOF/kt1fIubDZsA2TQYFijJF5fObpTr ENqcHhWmnGMSfyOZxlUbJ0wku9op0aF0E9V8g0Doq3mFOox33scGoFCU8ywe6lvQ9y3Q sNtg== X-Gm-Message-State: AOAM533FIInQiXS9dbNkoflUzg6atJxYITfmuJDi39avNL2erOMlSU37 Sf4HMcdy21QqJ2ne4tlJAWiIrw== X-Google-Smtp-Source: ABdhPJyU3533URMKEqcSoptMV2jIwg9UZB5n6VGkbS3uedpDRui2yjCE/cx+ISI1udiICS8cHioC6g== X-Received: by 2002:a17:90a:bf04:: with SMTP id c4mr944279pjs.149.1597151616039; Tue, 11 Aug 2020 06:13:36 -0700 (PDT) Received: from [192.168.1.182] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id s125sm17541177pfb.125.2020.08.11.06.13.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Aug 2020 06:13:35 -0700 (PDT) Subject: Re: [PATCH v2] loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE To: Martijn Coenen , Lennart Poettering Cc: linux-block , LKML , Christoph Hellwig , Yang Xu , Greg Kroah-Hartman References: <20200810171632.GA226564@gardel-login> From: Jens Axboe Message-ID: <9679c065-85c5-ad06-ddf0-a4c81158ebe5@kernel.dk> Date: Tue, 11 Aug 2020 07:13:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 8/11/20 12:49 AM, Martijn Coenen wrote: > On Mon, Aug 10, 2020 at 7:16 PM Lennart Poettering wrote: >> >> When LOOP_CONFIGURE is used with LO_FLAGS_PARTSCAN we need to propagate >> this into the GENHD_FL_NO_PART_SCAN. LOOP_SETSTATUS does this, >> LOOP_CONFIGURE doesn't so far. Effect is that setting up a loopback >> device with partition scanning doesn't actually work when LOOP_CONFIGURE >> is issued, though it works fine with LOOP_SETSTATUS. >> >> Let's correct that and propagate the flag in LOOP_CONFIGURE too. >> >> Fixes: 3448914e8cc5("loop: Add LOOP_CONFIGURE ioctl") >> >> Signed-off-by: Lennart Poettering >> Acked-by: Martijn Coenen > > Thanks, still looks good to me. Applied. -- Jens Axboe