From: "Yu Kuai" <yukuai@fnnas.com>
To: "Khazhismel Kumykov" <khazhy@chromium.org>,
"Tejun Heo" <tj@kernel.org>,
"Josef Bacik" <josef@toxicpanda.com>,
"Jens Axboe" <axboe@kernel.dk>
Cc: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Yu Kuai" <yukuai@kernel.org>,
"Khazhismel Kumykov" <khazhy@google.com>
Subject: Re: [PATCH v2 2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting
Date: Sat, 15 Nov 2025 23:53:35 +0800 [thread overview]
Message-ID: <96c6e645-6378-47b5-bdca-25900a1b60d0@fnnas.com> (raw)
In-Reply-To: <20251114235434.2168072-3-khazhy@google.com>
在 2025/11/15 7:54, Khazhismel Kumykov 写道:
> From: Guenter Roeck<linux@roeck-us.net>
>
> After the removal of CONFIG_BLK_DEV_THROTTLING_LOW, it is no longer
> necessary to enable block accounting, so remove the call to
> blk_stat_enable_accounting(). With that, the track_bio_latency variable
> is no longer used and can be deleted from struct throtl_data. Also,
> including blk-stat.h is no longer necessary.
>
> Fixes: bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
> Cc: Yu Kuai<yukuai@kernel.org>
> Cc: Tejun Heo<tj@kernel.org>
> Signed-off-by: Guenter Roeck<linux@roeck-us.net>
> Signed-off-by: Khazhismel Kumykov<khazhy@google.com>
> ---
> block/blk-throttle.c | 6 ------
> 1 file changed, 6 deletions(-)
LGTM
Reviewed-by: Yu Kuai <yukuai@fnnas.com>
--
Thanks
Kuai
next prev parent reply other threads:[~2025-11-15 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 23:54 [PATCH v2 0/3] block/blk-throttle: Fix throttle slice time for SSDs Khazhismel Kumykov
2025-11-14 23:54 ` [PATCH v2 1/3] " Khazhismel Kumykov
2025-11-15 15:51 ` Yu Kuai
2025-11-14 23:54 ` [PATCH v2 2/3] block/blk-throttle: drop unneeded blk_stat_enable_accounting Khazhismel Kumykov
2025-11-15 15:53 ` Yu Kuai [this message]
2025-11-14 23:54 ` [PATCH v2 3/3] block/blk-throttle: Remove throtl_slice from struct throtl_data Khazhismel Kumykov
2025-11-15 15:56 ` Yu Kuai
2025-11-17 16:42 ` [PATCH v2 0/3] block/blk-throttle: Fix throttle slice time for SSDs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96c6e645-6378-47b5-bdca-25900a1b60d0@fnnas.com \
--to=yukuai@fnnas.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=josef@toxicpanda.com \
--cc=khazhy@chromium.org \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tj@kernel.org \
--cc=yukuai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox