From: Guixin Liu <kanie@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: remove useless req addr print in debugfs
Date: Fri, 14 Mar 2025 11:04:49 +0800 [thread overview]
Message-ID: <97516917-9dc4-4d1f-908f-3bbdd8d7cb97@linux.alibaba.com> (raw)
In-Reply-To: <20250312084743.130021-1-kanie@linux.alibaba.com>
Gently ping...
Best Regards,
Guixin Liu
在 2025/3/12 16:47, Guixin Liu 写道:
> Using %p to print kernel address will only print a hashed address
> which is not the real address, this is useless for issue
> identification, simply remove it.
>
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
> ---
> block/blk-mq-debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index adf5f0697b6b..b4da95150d8d 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -265,7 +265,7 @@ int __blk_mq_debugfs_rq_show(struct seq_file *m, struct request *rq)
> BUILD_BUG_ON(ARRAY_SIZE(cmd_flag_name) != __REQ_NR_BITS);
> BUILD_BUG_ON(ARRAY_SIZE(rqf_name) != __RQF_BITS);
>
> - seq_printf(m, "%p {.op=", rq);
> + seq_printf(m, "{.op=");
> if (strcmp(op_str, "UNKNOWN") == 0)
> seq_printf(m, "%u", op);
> else
next prev parent reply other threads:[~2025-03-14 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:47 [PATCH] block: remove useless req addr print in debugfs Guixin Liu
2025-03-14 3:04 ` Guixin Liu [this message]
2025-03-14 14:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97516917-9dc4-4d1f-908f-3bbdd8d7cb97@linux.alibaba.com \
--to=kanie@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox